Skip to content

fix: adds low effort deepseek-v4-flash-0731 to the fireworks-ai provider - #3934

Merged
rekram1-node merged 1 commit into
anomalyco:devfrom
Adanlink:feat/deepseek-v4-flash-0731
Aug 3, 2026
Merged

fix: adds low effort deepseek-v4-flash-0731 to the fireworks-ai provider#3934
rekram1-node merged 1 commit into
anomalyco:devfrom
Adanlink:feat/deepseek-v4-flash-0731

Conversation

@Adanlink

@Adanlink Adanlink commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Adds low effort to the fireworks-ai provider of model DeepSeek-V4-Flash-0731.

Sources: the Hugging Face model card and config.json states that reasoning efforts are: low, high, max. Using its "Playground" I confirm that the low effort option works as intended.

I've tried to be careful in my sourcing, if there is any issue with the config tell me and I will correct it (or you can modify it yourself).

I recommend squashing the merge because I've had to resolve conflicts.

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

No actionable findings.

@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Action items

  • [high] [possible mistake] providers/fireworks-ai/models/accounts/fireworks/models/deepseek-v4-flash-0731.toml:10 - Check: DeepSeek V4 reasoning effort baseline (lab + same-host peers). Why: Effort is ["low", "high", "max"], but first-party DeepSeek V4 and all existing Fireworks DeepSeek V4 entries use ["high", "max"] only; the lab maps low/medium → high, so low is not a distinct native level. Action: Change to values = ["high", "max"] to match lab/Fireworks peers, or provide host evidence that Fireworks exposes low as a meaningfully different control (not just accepted and mapped to high).
  • [medium] [violation] providers/fireworks-ai/models/accounts/fireworks/models/deepseek-v4-flash-0731.toml:1 - Check: Every toggle needs a leading top-of-file wire-path comment. Why: The header is only a docs URL; it does not state the exact request field for on/off (e.g. thinking.type / reasoning_effort). Action: Replace/extend the leading comment with the exact Fireworks wire syntax for toggle and effort used by this model.

@Adanlink Adanlink changed the title feat: add deepseek-v4-flash-0731 to the fireworks-ai provider fix: adds low effort deepseek-v4-flash-0731 to the fireworks-ai provider Aug 2, 2026
@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Action items

  • [high] [violation] providers/fireworks-ai/models/accounts/fireworks/models/deepseek-v4-flash-0731.toml:10 - Check: DeepSeek V4 reasoning baseline (lab + same-surface peers). Why: effort includes low (["low", "high", "max"]). First-party DeepSeek V4 and Fireworks DeepSeek peers (deepseek-v4-flash, deepseek-v4-pro, and the existing base deepseek-v4-flash-0731) use toggle + ["high", "max"] only; AGENTS notes the lab maps low/mediumhigh, so low is not a distinct native level. Action: Change values to ["high", "max"] unless you can document that Fireworks exposes low as a real distinct control for this model (not accept-and-alias).
  • [high] [violation] models/deepseek/deepseek-v4-flash-0731.toml:1 / providers/fireworks-ai/models/accounts/fireworks/models/deepseek-v4-flash-0731.toml:1 - Check: PR must not recreate or regress paths already on base. Why: Both files already exist on current dev with a complete lab entry and a Fireworks host using high/max. This PR’s lab TOML would drop temperature, structured_output, knowledge, license, and benchmarks and rewrite context to 1_048_576 vs the established lab 1_000_000. Action: Rebase onto current dev; remove the lab-file add if unchanged; only keep a Fireworks delta if something is still missing after rebase.
  • [medium] [violation] providers/fireworks-ai/models/accounts/fireworks/models/deepseek-v4-flash-0731.toml:1 - Check: Every toggle needs a leading top-of-file wire-path comment. Why: The header is only a docs URL (# https://docs.fireworks.ai/guides/reasoning), not the request field used to enable/disable reasoning (e.g. thinking.type / equivalent on Fireworks). Action: Replace with an exact wire comment for this host’s on/off control (and effort field), matching Fireworks DeepSeek peer style.

@Adanlink

Adanlink commented Aug 2, 2026

Copy link
Copy Markdown
Contributor Author

[high] [violation] providers/fireworks-ai/models/accounts/fireworks/models/deepseek-v4-flash-0731.toml:10 - Check: DeepSeek V4 reasoning baseline (lab + same-surface peers). Why: effort includes low (["low", "high", "max"]). First-party DeepSeek V4 and Fireworks DeepSeek peers (deepseek-v4-flash, deepseek-v4-pro, and the existing base deepseek-v4-flash-0731) use toggle + ["high", "max"] only; AGENTS notes the lab maps low/medium → high, so low is not a distinct native level. Action: Change values to ["high", "max"] unless you can document that Fireworks exposes low as a real distinct control for this model (not accept-and-alias).

Can't document it because there is no documentation to my knowledge about Fireworks AI stating the efforts supported. But by testing, you can truly see the obvious difference and that "low" is a real option (apart of also having the official Hugging Face website saying so; you can check).

[high] [violation] models/deepseek/deepseek-v4-flash-0731.toml:1 / providers/fireworks-ai/models/accounts/fireworks/models/deepseek-v4-flash-0731.toml:1 - Check: PR must not recreate or regress paths already on base. Why: Both files already exist on current dev with a complete lab entry and a Fireworks host using high/max. This PR’s lab TOML would drop temperature, structured_output, knowledge, license, and benchmarks and rewrite context to 1_048_576 vs the established lab 1_000_000. Action: Rebase onto current dev; remove the lab-file add if unchanged; only keep a Fireworks delta if something is still missing after rebase.

Let me rebase it then...

[medium] [violation] providers/fireworks-ai/models/accounts/fireworks/models/deepseek-v4-flash-0731.toml:1 - Check: Every toggle needs a leading top-of-file wire-path comment. Why: The header is only a docs URL (# https://docs.fireworks.ai/guides/reasoning), not the request field used to enable/disable reasoning (e.g. thinking.type / equivalent on Fireworks). Action: Replace with an exact wire comment for this host’s on/off control (and effort field), matching Fireworks DeepSeek peer style.

To adapt to what was already commited, I preferred to stay with the style of rekram1-node. If that's wrong I will correct it.

@Adanlink
Adanlink force-pushed the feat/deepseek-v4-flash-0731 branch from 0a88ecb to 97dffe6 Compare August 2, 2026 20:01
@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Action items

  • [medium] [violation] providers/fireworks-ai/models/accounts/fireworks/models/deepseek-v4-flash-0731.toml:8 - Check: DeepSeek V4 reasoning effort baseline (AGENTS.md / audit-reasoning-options). Why: First-party DeepSeek documents reasoning_effort = high|max and that low/medium map to high (providers/deepseek/provider.toml). Lab entries and same-host Fireworks peers (deepseek-v4-flash, deepseek-v4-pro) use ["high", "max"] only. Expanding to ["low", "high", "max"] lists a non-distinct level and matches the documented anti-pattern of forcing extra L/M/H-style values onto DeepSeek V4. HF weights/config or a playground accepting "low" is not enough if the host maps it to high. Action: Keep values = ["high", "max"], or provide Fireworks-host evidence that low is a separate effective effort (not accepted-and-mapped).

@rekram1-node
rekram1-node merged commit ec4da28 into anomalyco:dev Aug 3, 2026
2 checks passed
@Adanlink
Adanlink deleted the feat/deepseek-v4-flash-0731 branch August 3, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants