Skip to content

Fix deck names related argument crash in DeckSelectionDialog#21092

Merged
david-allison merged 1 commit into
ankidroid:mainfrom
lukstbit:fix_deckSelection
May 19, 2026
Merged

Fix deck names related argument crash in DeckSelectionDialog#21092
david-allison merged 1 commit into
ankidroid:mainfrom
lukstbit:fix_deckSelection

Conversation

@lukstbit
Copy link
Copy Markdown
Member

Purpose / Description

I've incorrectly modified how the decks arguments was fetched in DeckSelectionDialog. This incorrect version works on API levels 34 and above, but crashes on lower versions.
I reverted to the previous implementation, this part of the code will be removed anyway.

Fixes

How Has This Been Tested?

Ran on lower versions.

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Copy link
Copy Markdown
Contributor

@Giyutomioka-SS Giyutomioka-SS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@david-allison david-allison added this pull request to the merge queue May 19, 2026
Merged via the queue into ankidroid:main with commit ea5fce8 May 19, 2026
20 checks passed
@github-actions github-actions Bot added this to the 2.25 release milestone May 19, 2026
@lukstbit lukstbit deleted the fix_deckSelection branch May 19, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Note crashes when selecting a deck

3 participants