refactor: move 10 strings to the backend translations #21090
Open
david-allison wants to merge 3 commits into
Open
refactor: move 10 strings to the backend translations #21090david-allison wants to merge 3 commits into
david-allison wants to merge 3 commits into
Conversation
Ensures backend strings are used for all actions Assisted-by: Claude Opus 4.7
We want to use backend strings for most of these, better in `title` Assisted-by: Claude Opus 4.7
Removes a number of strings from 01-core With a primary focus on ViewerAction Assisted-by: Claude Opus 4.7
Contributor
|
Important Maintainers: This PR contains Strings changes
|
lukstbit
approved these changes
May 20, 2026
| findPreference<ControlPreference>(getString(R.string.remove_flag_command_key))?.let { | ||
| it.title = getString(R.string.gesture_flag_remove).toSentenceCase(R.string.sentence_gesture_flag_remove) | ||
| } | ||
| findPreference<ControlPreference>(getString(R.string.bury_card_command_key))?.let { |
Member
There was a problem hiding this comment.
I don't see why the other preferences' titles in this file are sentence case.
lukstbit
added
Needs Second Approval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Assisted-by: Claude Opus 4.7 - all
Purpose / Description
This means less work for our translators - especially as 01-core is required for a translation to be included in the app
How Has This Been Tested?
I opened the menu + bury/suspend submenus in the old/new study screen, API 29 emulator
Checklist