feat: move and rename "Safe display" pref #21079
Merged
Merged
Conversation
Contributor
|
Important Maintainers: This PR contains Strings changes
|
Contributor
|
Snapshot diff report vs
All 2 changed screenshotsPreferencesScreenshotTest
|
5 tasks
david-allison
approved these changes
May 18, 2026
Member
|
Timebox 12 hours for a second approval, then merge |
59eb87f to
1c5d75b
Compare
only the "animator" setting is necessary for that goal. The other ones are actually unrelated
to the accessibility settings note: the "use safer method for drawing cards" part apparently does nothing, based on the current uses of the preference
it could be confused or conflict with `android.view.animation.AnimationUtils`
lukstbit
approved these changes
May 19, 2026
Contributor
|
Maintainers: Please Sync Translations to produce a commit with only the automated changes from this PR. Read more about updating strings on the wiki, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
to the accessibility settings
note: the "use safer method for drawing cards" part apparently does nothing, based on the current uses of the preference
Approach
In the commits
How Has This Been Tested?
Emulator 31
Screen_recording_20260518_115911.webm
FAB pressed color is bugged, I know. Already fixed on a rebase
Screen_recording_20260518_123750.webm
Checklist
Please, go through these checks before submitting the PR.