Skip to content

test: reduce date and version noise in AboutFragment test#21077

Merged
lukstbit merged 1 commit into
ankidroid:mainfrom
BrayanDSO:test/about
May 18, 2026
Merged

test: reduce date and version noise in AboutFragment test#21077
lukstbit merged 1 commit into
ankidroid:mainfrom
BrayanDSO:test/about

Conversation

@BrayanDSO
Copy link
Copy Markdown
Member

Purpose / Description

The date in AboutFragment changes when a commit is done on a new day, which generates noise on its screenshot test. Same for new versions

#21075 (comment)

Note

The version of Anki's backend and FSRS may generate diffs as well, but upgrading them is a rare event, so I kept the diff as an extra "confirmation" after doing the upgrades

How Has This Been Tested?

./gradlew :AnkiDroid:recordRoborazziPlayDebug -Pscreenshot --tests "com.ichi2.anki.preferences.*"

Details AboutFragment

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Copy link
Copy Markdown
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cheers

Comment thread AnkiDroid/src/test/java/com/ichi2/anki/preferences/PreferencesScreenshotTest.kt Outdated
@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels May 18, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 18, 2026

Snapshot diff report vs main. Open screenshot-diff for diffs.

  • PreferencesScreenshotTest: 1 change
All 1 changed screenshots

PreferencesScreenshotTest

  • AboutFragment_compare.png

Copy link
Copy Markdown
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels May 18, 2026
@lukstbit lukstbit enabled auto-merge May 18, 2026 12:03
@lukstbit lukstbit added this pull request to the merge queue May 18, 2026
Merged via the queue into ankidroid:main with commit 7d45477 May 18, 2026
21 checks passed
@github-actions github-actions Bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label May 18, 2026
@github-actions github-actions Bot added this to the 2.25 release milestone May 18, 2026
@BrayanDSO BrayanDSO deleted the test/about branch May 18, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants