Skip to content

refactor: removed the Unexpected empty object pattern - #3386

Closed
alkavats1 wants to merge 2 commits into
angular:mainfrom
alkavats1:emptyObject
Closed

alkavats1 wants to merge 2 commits into
angular:mainfrom
alkavats1:emptyObject

Conversation

@alkavats1

Copy link
Copy Markdown
Contributor

removed the empty object declaration from the collections

Checklist

  • Issue number for this PR: #nnn (required)
  • Docs included?: (yes/no; required for all API/functional changes)
  • Test units included?: (yes/no; required)
  • In a clean directory, yarn install, yarn test run successfully? (yes/no; required)

Description

Code sample

removed the empty object declaration from the collections
@davideast
davideast enabled auto-merge (squash) June 23, 2023 14:45
@davideast
davideast self-requested a review June 23, 2023 14:59
@davideast davideast self-assigned this Jun 23, 2023
@alkavats1

Copy link
Copy Markdown
Contributor Author

Hi @davideast please review this PR and merge
Thanks

1 similar comment
@alkavats1

Copy link
Copy Markdown
Contributor Author

Hi @davideast please review this PR and merge
Thanks

@armando-navarro

Copy link
Copy Markdown
Collaborator

Thanks for the effort here. Closing because the branch has aged into conflicts and it targets the compat layer, while active development is happening on the modular API. If there's a bug the refactor was fixing (rather than a cleanup), please open an issue and we'll look at it directly.

auto-merge was automatically disabled July 22, 2026 02:29

Pull request was closed

@armando-navarro armando-navarro added comp: compat Compatibility layer for the pre-modular API (src/compat). obsolete Confirmed no longer relevant (removed/deprecated surface or superseded); closed as not planned. type: chore Maintenance with no user-facing behavior change. labels Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: compat Compatibility layer for the pre-modular API (src/compat). obsolete Confirmed no longer relevant (removed/deprecated surface or superseded); closed as not planned. type: chore Maintenance with no user-facing behavior change.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants