feat: add :featured-lint-rules Android Lint module with HardcodedFlagValue detector by kirich1409 · Pull Request #141 · androidbroadcast/Featured

kirich1409 · 2026-03-23T12:19:39Z

Summary

Adds new :featured-lint-rules Gradle module published to Maven Central as featured-lint-rules
Implements HardcodedFlagValueDetector — fires when .defaultValue is accessed directly on a ConfigParam, using full UAST type resolution (zero false positives vs. the name-based heuristic in featured-detekt-rules)
Adds @Suppress("HardcodedFlagValue") to ConfigValues.kt internal fallback path (legitimate access that must be silenced)

Why Lint alongside Detekt

Detekt's HardcodedFlagValueRule fires on any x.defaultValue where x is a simple name — it cannot resolve types. The Lint version uses JavaEvaluator.extendsClass against the compiled classpath, so it only fires when the receiver is truly a ConfigParam.

Test Plan

./gradlew :featured-lint-rules:check passes (7 tests, BCV, spotless)
unzip -p featured-lint-rules/build/libs/featured-lint-rules.jar META-INF/MANIFEST.MF contains Lint-Registry-v2: dev.androidbroadcast.featured.lint.FeaturedIssueRegistry
Verify @Suppress("HardcodedFlagValue") on ConfigValues.kt:94 suppresses the rule correctly in an Android project consuming the artifact

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- Scope UncheckedFlagAccess to same-file only (consistent with all existing rules, avoids FQN/lifecycle ambiguity without type resolution) - Specify two-pass accumulator algorithm for ordering safety - Add companion object exclusion corner case and test coverage - Document Debt constants, koverVerify note, FeaturedRuleSetProvider KDoc update Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

KMP project requires cross-file analysis. UncheckedFlagAccess now uses BindingContext via detektWithTypeResolution task. InvalidFlagReference remains PSI-only. Documents BindingContext.EMPTY guard and Gradle setup. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…tion pseudocode, minApi, stub bound, code-sharing rationale Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…dule Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

@test

Also add testImplementation(lint.api) to fix test classpath resolution, and @RunWith(JUnit4::class) to make @test methods visible to Gradle's JUnit runner (LintDetectorTest extends JUnit3 TestCase). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…figValues test expectation

…nt, constructor-free tests, stronger unrelated-type test, suppress in ConfigValues

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…e behavior

Copilot

Pull request overview

Adds a new Android Lint rules artifact (:featured-lint-rules) to complement the existing Detekt rules by detecting direct ConfigParam.defaultValue reads using UAST + type resolution, and wires in suppression for the known-safe fallback path in ConfigValues.

Changes:

Introduces :featured-lint-rules (published as featured-lint-rules) with HardcodedFlagValueDetector + FeaturedIssueRegistry.
Adds Lint dependencies/version catalog entries and registers the new module in Gradle settings.
Documents the design/plan for the lint pilot (plus additional specs/plans added in this PR) and suppresses the rule at the ConfigValues default fallback.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
settings.gradle.kts	Includes the new `:featured-lint-rules` module.
gradle/libs.versions.toml	Adds `lint` version + `lint-api`/`lint-tests` dependencies for the new module.
featured-lint-rules/build.gradle.kts	Configures the JVM lint-rules module, publishing, and `Lint-Registry-v2` manifest attribute.
featured-lint-rules/src/main/kotlin/dev/androidbroadcast/featured/lint/HardcodedFlagValueDetector.kt	Implements the UAST-based detector for `ConfigParam.defaultValue` access.
featured-lint-rules/src/main/kotlin/dev/androidbroadcast/featured/lint/FeaturedIssueRegistry.kt	Registers the lint issues and vendor metadata.
featured-lint-rules/src/test/kotlin/dev/androidbroadcast/featured/lint/HardcodedFlagValueDetectorTest.kt	Adds lint-tests coverage for positive/negative scenarios.
featured-lint-rules/api/featured-lint-rules.api	Adds BCV API surface snapshot for the new published module.
docs/superpowers/specs/2026-03-23-featured-lint-rules-design.md	Design spec for the lint-rules pilot and detector behavior.
docs/superpowers/specs/2026-03-23-behind-flag-annotation-design.md	Adds a draft design spec for future flag-guard annotations/rules.
docs/superpowers/specs/2026-03-22-agp9-migration-design.md	Adds an AGP9 migration design document (context/planning).
docs/superpowers/plans/2026-03-23-featured-lint-rules.md	Implementation plan for `:featured-lint-rules`.
docs/superpowers/plans/2026-03-23-behind-flag-annotation.md	Implementation plan for `@BehindFlag/@AssumesFlag` + detekt rules.
docs/superpowers/plans/2026-03-22-agp9-migration.md	Implementation plan for the AGP9 migration workstream.
core/src/commonMain/kotlin/dev/androidbroadcast/featured/ConfigValues.kt	Suppresses `HardcodedFlagValue` at the intentional default fallback.

Copilot · 2026-03-23T12:24:39Z

...-lint-rules/src/main/kotlin/dev/androidbroadcast/featured/lint/HardcodedFlagValueDetector.kt

+            override fun visitSimpleNameReferenceExpression(node: USimpleNameReferenceExpression) {
+                // Only care about references named "defaultValue"
+                if (node.identifier != DEFAULT_VALUE_PROPERTY) return
+
+                // Must be the selector of a qualified expression: receiver.defaultValue
+                val parent = node.uastParent as? UQualifiedReferenceExpression ?: return
+
+                // Resolve the receiver's type
+                val receiverType = parent.receiver.getExpressionType() as? PsiClassType ?: return
+                val receiverClass = receiverType.resolve() ?: return
+


visitSimpleNameReferenceExpression assumes any defaultValue identifier inside a UQualifiedReferenceExpression is the selector (i.e., receiver.defaultValue). But the same AST shape occurs when a variable/property named defaultValue is used as the receiver (e.g., defaultValue.key). In that case this detector will incorrectly report a violation if defaultValue happens to be a ConfigParam. Please guard against this by verifying the defaultValue node is the qualified expression’s selector (or switch to visiting UQualifiedReferenceExpression and checking its selector name) before resolving the receiver type.

Copilot · 2026-03-23T12:24:39Z

...t-rules/src/test/kotlin/dev/androidbroadcast/featured/lint/HardcodedFlagValueDetectorTest.kt

+    @Test
+    fun `does not report defaultValue on String receiver`() {
+        lint()
+            .files(
+                configParamStub,
+                kotlin(
+                    """
+                    fun check(s: String) {
+                        println(s.defaultValue)
+                    }
+                    """,
+                ).indented(),
+            )
+            .run()
+            .expectClean()
+    }


Consider adding a regression test for the false-positive case where a ConfigParam-typed variable/property is named defaultValue and used as a receiver (e.g., val defaultValue: ConfigParam<Boolean> = …; println(defaultValue.key)). The current suite doesn’t cover this, and the detector logic can easily regress here because it visits all USimpleNameReferenceExpressions named defaultValue.

…ession test Guard against false positives when a ConfigParam-typed variable is named "defaultValue" and used as a receiver (e.g. defaultValue.key). The detector now verifies the "defaultValue" node is the selector of the qualified expression (not the receiver) before resolving the receiver type. Adds a regression test covering this case so the selector-position guard cannot silently regress. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

kirich1409 and others added 19 commits March 22, 2026 16:33

docs: add AGP 9 migration design spec

b0c26be

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

docs: add AGP 9 migration implementation plan

2602f14

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

docs: add design spec for @BehindFlag / @AssumesFlag annotations

ff85220

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

docs: add implementation plan for @BehindFlag/@AssumesFlag

a1a5993

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

docs: add design spec for featured-lint-rules Android Lint pilot

bf2a2cc

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

docs: revise featured-lint-rules spec — fix UAST visitor, type resolu…

0b9722b

…tion pseudocode, minApi, stub bound, code-sharing rationale Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

docs: add implementation plan for featured-lint-rules Android Lint mo…

338f493

…dule Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

chore: add lint-api and lint-tests to version catalog

7eef711

chore: scaffold :featured-lint-rules module

7b83ba5

chore: document AGP/lint version coupling in version catalog

0434e06

test: add failing tests for HardcodedFlagValueDetector

761a381

chore: add FeaturedIssueRegistry scaffold

7dae9dc

fix: add testImplementation lint-api, RunWith annotation, correct Con…

e0c7f30

…figValues test expectation

fix: address code review — KDoc on registry, testImplementation comme…

e7311b0

…nt, constructor-free tests, stronger unrelated-type test, suppress in ConfigValues

chore: add BCV API dump for featured-lint-rules

ad1ecae

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

test: clarify ConfigValues test — use TODO() body to isolate call-sit…

86949c5

…e behavior

Copilot AI review requested due to automatic review settings March 23, 2026 12:19

Copilot started reviewing on behalf of kirich1409 March 23, 2026 12:20 View session

Copilot AI reviewed Mar 23, 2026

View reviewed changes

kirich1409 merged commit 6884dae into main Mar 23, 2026
8 of 9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add :featured-lint-rules Android Lint module with HardcodedFlagValue detector#141

feat: add :featured-lint-rules Android Lint module with HardcodedFlagValue detector#141
kirich1409 merged 20 commits intomainfrom
feat/featured-lint-rules

kirich1409 commented Mar 23, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 23, 2026

Uh oh!

Copilot AI Mar 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

kirich1409 commented Mar 23, 2026

Summary

Why Lint alongside Detekt

Test Plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants