Update dependencies#887
Conversation
MagicalMeghan
requested review from
a team,
kkuan2011 and
yrezgui
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates numerous dependency versions in the version catalog, migrates Compose test imports to the v2 package, and increments the Gradle wrapper version. Review feedback identifies several likely typos in version numbers for the Compose BOM, Kotlin, and Mockito-Kotlin. Additionally, there is a concern regarding the activation of a specific AndroidX snapshot version in the Gradle properties, which may impact build stability and reproducibility.
| androidx-cameraX = "1.6.0" | ||
| androidx-car = "1.7.0" | ||
| androidx-compose-bom = "2026.03.00" | ||
| androidx-compose-bom = "2026.04.01" |
There was a problem hiding this comment.
The Compose BOM version 2026.04.01 appears to be a typo. BOM versions typically follow the YYYY.MM.VV format, and 2026 is in the future. Please verify if 2024.04.01 or a similar current version was intended.
| androidx-compose-bom = "2026.04.01" | |
| androidx-compose-bom = "2024.10.01" |
| horologist = "0.8.3-alpha" | ||
| junit = "4.13.2" | ||
| kotlin = "2.3.10" | ||
| kotlin = "2.3.21" |
There was a problem hiding this comment.
Kotlin version 2.3.21 is not a valid release. The current stable versions are in the 2.0.x or 2.1.x range. This is likely a typo for 2.0.21 or 2.1.0.
| kotlin = "2.3.21" | |
| kotlin = "2.0.21" |
| mockitoKotlin = "5.3.1" | ||
| media3 = "1.10.0" | ||
| media3Ui = "1.10.0" | ||
| mockitoKotlin = "6.3.0" |
There was a problem hiding this comment.
The version 6.3.0 for mockitoKotlin appears to be invalid. The current stable major version is 5.x. Using a non-existent version will cause dependency resolution to fail.
| mockitoKotlin = "6.3.0" | |
| mockitoKotlin = "5.4.0" |
| # Use an AndroidX snapshot build. | ||
| # https://androidx.dev/snapshots/builds | ||
| # snapshotVersion=14793336 No newline at end of file | ||
| snapshotVersion=14793336 |
There was a problem hiding this comment.
Uncommenting snapshotVersion forces the build to use a specific AndroidX snapshot. This is typically used for temporary testing of unreleased features and can lead to non-reproducible builds. If this PR is intended for a stable baseline, this should remain commented out.
# snapshotVersion=14793336
kul3r4
left a comment
kul3r4
left a comment
There was a problem hiding this comment.
LGTM for updating Wear dependenciws
kkuan2011
left a comment
kkuan2011
left a comment
There was a problem hiding this comment.
looks good after these comments are addressed!
| # AndroidX package structure to make it clearer which packages are bundled with the | ||
| # Android operating system, and which are packaged with your app's APK | ||
| # https://developer.android.com/topic/libraries/support-library/androidx-rn | ||
| android.useAndroidX=true |
There was a problem hiding this comment.
are lines 21-24 needed? I thought useAndroidX is true by default now?
| # Use an AndroidX snapshot build. | ||
| # https://androidx.dev/snapshots/builds | ||
| # snapshotVersion=14793336 No newline at end of file | ||
| snapshotVersion=14793336 |
There was a problem hiding this comment.
I think Dereck added this as an example in a comment, but I don't think we need to use a snapshot build for anything right now, unless you're aware of any code that requires it?
There was a problem hiding this comment.
agreed to take this out esp for main branch
| android.enableR8.fullMode=true | ||
|
|
||
| android.newDsl=false | ||
| android.newDsl=true |
There was a problem hiding this comment.
since this is true by default, you can remove it now
https://developer.android.com/build/releases/agp-9-0-0-release-notes#android-gradle-plugin-behavior-changes
| gradle-versions = "0.53.0" | ||
| guava = "33.5.0-jre" | ||
| guava-android = "33.5.0-jre" | ||
| health-connect = "1.1.0-alpha11" |
There was a problem hiding this comment.
I think health-connect accidentally got deleted, which is causing the spotless check + build to fail, can you add it back? :)
…roid/snippets into mm/snippet-update-2026-04-27
3 participants
Update dependencies for Compose 1.11