-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Apply flowOn(defaultDispatchers) for main-safe. #1238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion. I'll accept your suggestion. |
...google/samples/apps/nowinandroid/core/data/repository/CompositeUserNewsResourceRepository.kt
Outdated
Show resolved
Hide resolved
|
Getting a build error: |
|
#1250 This issue had given the clue that how to solve the test fail problems when I was struggling with some tests fail. Thanks. |
|
Please resolve the remaining merge issue so we can proceed to merge this PR. |
|
@keyboardsurfer I resolved a conflict and applied a spotless. |
|
The error you're seeing is from a dependency issue which has been resolved on |
Change-Id: I04d005004d4fd6b813e625a1865edf5b65f2a5c8
Change-Id: I81c5e020fe2632f1c1ad6ca411df59fb0e867ce9
Rebase code
|
@keyboardsurfer Thank you for waiting me solving a conflict. I rebased it, and it's ready to merge. |
Change-Id: Id4ec69492518663bdbae5c4965183f7b6dff8cb9

What I have done and why
I've added withContext(defaultDispatcher) for main-safe at combine.
Fix #1420
DefaultSearchContentsRepository.searchContents
DefaultSearchContentsRepository.getSearchContentsCount
GetFollowableTopicsUseCase.invoke
Flow.mapToUserSearchResult