Skip to content

Conversation

@raystatic
Copy link

Added toml versioning for basics codelab as it was creating friction with Android Studio Started project template.

Friction Log: https://docs.google.com/document/d/1xvMKa9fv7SsNpWhnoxX376Mvfivat9tzj5PjxgCL0qI/edit?tab=t.0#heading=h.evwnjzlk8wx7

@raystatic raystatic requested a review from a team as a code owner January 24, 2026 22:08
@gemini-code-assist
Copy link

Summary of Changes

Hello @raystatic, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the dependency and plugin management within the BasicsCodelab project by introducing Gradle Version Catalogs. This modernization centralizes all version declarations in a single TOML file, enhancing maintainability and consistency across the build scripts. The primary motivation is to resolve compatibility issues encountered when integrating with Android Studio's default project templates, thereby improving the developer experience.

Highlights

  • Migration to Gradle Version Catalogs: The project's dependency and plugin management has been updated to use Gradle Version Catalogs, centralizing version declarations for improved consistency and maintainability.
  • Centralized Version Management: All plugin and library versions are now defined in the newly introduced libs.versions.toml file, ensuring a single source of truth for dependency versions.
  • Improved Compatibility with Android Studio: This change directly addresses and resolves friction encountered when using Android Studio's started project templates, streamlining the development workflow.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully migrates the project to use Gradle Version Catalogs by introducing a libs.versions.toml file and updating the build scripts to reference it. This is a great improvement for dependency management. My review includes a few suggestions for the new libs.versions.toml file to improve clarity and adhere to common conventions, such as renaming an ambiguous version alias and using dot notation for library and plugin aliases for better organization.

kotlin = "2.3.0"
coreKtx = "1.17.0"
junit = "4.13.2"
junitVersion = "1.3.0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The version alias junitVersion is ambiguous as there is also a junit version defined just above. Since this version corresponds to androidx.test.ext:junit (used on line 15), renaming it to androidxJunit would make it more descriptive and prevent confusion. Remember to update the version.ref on line 15 accordingly.

Suggested change
junitVersion = "1.3.0"
androidxJunit = "1.3.0"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one is worth addressing

@raystatic raystatic self-assigned this Jan 24, 2026
@raystatic raystatic requested a review from riggaroo January 24, 2026 22:10
Copy link
Contributor

@riggaroo riggaroo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm, you might just want to address the feedback on the junit version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants