-
Notifications
You must be signed in to change notification settings - Fork 776
Added toml versioning in basics codelab #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Added toml versioning in basics codelab #562
Conversation
Summary of ChangesHello @raystatic, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the dependency and plugin management within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully migrates the project to use Gradle Version Catalogs by introducing a libs.versions.toml file and updating the build scripts to reference it. This is a great improvement for dependency management. My review includes a few suggestions for the new libs.versions.toml file to improve clarity and adhere to common conventions, such as renaming an ambiguous version alias and using dot notation for library and plugin aliases for better organization.
| kotlin = "2.3.0" | ||
| coreKtx = "1.17.0" | ||
| junit = "4.13.2" | ||
| junitVersion = "1.3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version alias junitVersion is ambiguous as there is also a junit version defined just above. Since this version corresponds to androidx.test.ext:junit (used on line 15), renaming it to androidxJunit would make it more descriptive and prevent confusion. Remember to update the version.ref on line 15 accordingly.
| junitVersion = "1.3.0" | |
| androidxJunit = "1.3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this one is worth addressing
riggaroo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall lgtm, you might just want to address the feedback on the junit version
Added toml versioning for basics codelab as it was creating friction with Android Studio Started project template.
Friction Log: https://docs.google.com/document/d/1xvMKa9fv7SsNpWhnoxX376Mvfivat9tzj5PjxgCL0qI/edit?tab=t.0#heading=h.evwnjzlk8wx7