fix: respect Grype fail-on-severity configuration - #727
Open
ychampion wants to merge 1 commit into
Open
Conversation
Constraint: Preserve the existing medium fallback when neither the action input nor Grype config sets a cutoff. Confidence: high Scope-risk: narrow Tested: Node 24 command tests; repository test set; lint; format; build Signed-off-by: ychampion <ychampion@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fail-on-severitywhen the action input is unsetmediumfallback and compatibility with older Grype releasesWhy
The action currently passes
--fail-on mediumeven whenseverity-cutoffis omitted, overriding the value from.grype.yamlor another Grype config file. Fixes #674.Validation
npx --yes node@24 --test --experimental-test-module-mocks --conditions=import --test-timeout=90000 --test-concurrency=1 tests/grype_command.test.js— 12 passednpm run lint— passednpx prettier --check '*.js' 'tests/*.js'— passednpm run build— passednpm run run-tests— 31 tests passed together; the two image-heavy SARIF fixtures then passed individually with the same pinned database