fix: declare registry-username and registry-password inputs in action.yml - #708
Open
Unlxii wants to merge 2 commits into
Open
fix: declare registry-username and registry-password inputs in action.yml#708Unlxii wants to merge 2 commits into
Unlxii wants to merge 2 commits into
Conversation
….yml `registry-username` and `registry-password` were added to the README and implemented in `action.js` (via `core.getInput()`) in anchore#158, but were never declared in `action.yml`. This means the inputs are functionally supported but undocumented in the action metadata — no IDE autocomplete, no validation, and the inputs table in README references inputs that don't appear in `action.yml`. This PR adds the missing declarations to `action.yml` to match the existing implementation. Signed-off-by: tteenntt <87744652+Unlxii@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes the action metadata by declaring the registry-username and registry-password inputs in action.yml, aligning the documented/implemented inputs (added in #158) with the GitHub Action’s published interface so they appear in IDE autocomplete and are validated as supported inputs.
Changes:
- Added
registry-usernameinput declaration toaction.yml. - Added
registry-passwordinput declaration toaction.yml.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+19
to
+21
| registry-password: | ||
| description: "The registry password to use when authenticating to an external registry" | ||
| required: false |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: tteenntt <87744652+Unlxii@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: declare registry-username and registry-password inputs in action.yml
registry-usernameandregistry-passwordwere added to the README and implemented inaction.js(viacore.getInput()) in #158, but were never declared inaction.yml.This means the inputs are functionally supported but undocumented in the action metadata — no IDE autocomplete, no validation, and the inputs table in README references inputs that don't appear in
action.yml.This PR adds the missing declarations to
action.ymlto match the existing implementation.