arm64: dts: zynqmp-zcu102-rev10-adrv904x: fix AD9528 reset GPIO polarity - #3464
Open
stefpopa wants to merge 1 commit into
Open
arm64: dts: zynqmp-zcu102-rev10-adrv904x: fix AD9528 reset GPIO polarity#3464stefpopa wants to merge 1 commit into
stefpopa wants to merge 1 commit into
Conversation
The AD9528 driver was updated in commit 907be26 ("iio: frequency: ad9528: Fix reset logic") to follow Linux GPIO convention where reset GPIOs are active-high from the driver's viewpoint, with active-low polarity communicated via devicetree properties. Add GPIO_ACTIVE_LOW flag to the AD9528 reset-gpios to match the updated driver behavior. Without this fix, the AD9528 probe fails with error -5 (EIO) because the chip remains in reset. Fixes: 907be26 ("iio: frequency: ad9528: Fix reset logic") Signed-off-by: Stefan Popa <stefan.popa@analog.com>
stefpopa
requested review from
CiprianRegus,
amiclaus,
btogorean,
buha,
chegbeli,
danmois,
dbogdan,
machschmitt,
mhennerich,
nunojsa and
rbolboac
as code owners
July 28, 2026 14:49
amiclaus
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
The AD9528 driver was updated in commit 907be26 ("iio: frequency: ad9528: Fix reset logic") to follow Linux GPIO convention where reset GPIOs are active-high from the driver's viewpoint, with active-low polarity communicated via devicetree properties.
Add GPIO_ACTIVE_LOW flag to the AD9528 reset-gpios to match the updated driver behavior. Without this fix, the AD9528 probe fails with error -5 (EIO) because the chip remains in reset.
Fixes: 907be26 ("iio: frequency: ad9528: Fix reset logic")
PR Type
PR Checklist