test: migrate remaining mkdtempSync sites to createTempDir (PR #814 follow-up)

[kelsonpw]

Summary

Finishes the migration started in #814. PR #814 extracted the shared createTempDir helper at src/utils/__tests__/helpers/temp-dir.ts and migrated 27 of the ~75 test files that inlined mkdtempSync + rmSync patterns. This PR migrates the remaining 46 test files to use the same helper.

Stacked on refactor/extract-temp-dir-helper; merge after #814.

Migration count

46 files migrated across 6 commits. Each commit groups files by directory / pattern so the diff stays reviewable:

1. batch 1 — 9 single-call src/lib/__tests__/ files
2. batch 2 — 7 multi-call src/lib/__tests__/ files (wizard-tools keeps makeTmpDir/cleanup wrappers that delegate to the helper, since 30+ callsites use them)
3. batch 3 — 5 remaining src/lib/__tests__/ files (4-site ampli-config, download-skill; in-it()-block patterns)
4. batch 4 — 7 src/lib/{agent,middleware,observability,orchestration,wizard-tools}/__tests__/ files
5. batch 5 — 8 src/ui/tui/screens/__tests__/ files
6. batch 6 — 10 remaining files: src/__tests__/cli.test.ts, src/commands/__tests__/, src/steps/__tests__/, src/ui/tui/{primitives,components,utils}/__tests__/, src/ui/tui/__tests__/store.test.ts

Files (deduped against PR #814)

Zero overlap with #814's 27-file list. All migrated files in this PR are net-new to the migration. The full list is the diff of this branch against refactor/extract-temp-dir-helper.

Tests

• Before: 4474 passing
• After: 4474 passing (same count, same pnpm test baseline)

Verification

• pnpm tsc --noEmit clean
• pnpm lint clean
• pnpm test — 4474/4474 pass
• src/utils/wizard-abort.ts untouched (per scope)
• No non-test source code modified
• Zero overlap with PR refactor(test): extract createTempDir shared test helper #814's file list (verified via diff vs refactor(test): extract createTempDir shared test helper #814's branch)
• No remaining mkdtempSync calls in src/**/__tests__/*.test.{ts,tsx} (except the helper's own test)
• Worktree at /tmp/temp-dir-cont will be removed after merge

Patterns preserved

• Best-effort cleanup (try { rmSync(...) } catch {}) becomes try { cleanup() } catch {} — same semantics.
• In-it() ad-hoc dirs (e.g. download-skill.test.ts host-allowlist cases, file-change-ledger.test.ts "outside install dir" case) become inline createTempDir(...) + try/finally cleanup().
• Local makeTmpDir / cleanup(dir) wrapper functions (e.g. dashboard-plan.test.ts, diagnostics-collector.test.ts, wizard-tools.test.ts) — refactored to delegate to the helper.
• Tests with no pre-existing cleanup (e.g. OutroScreen.overdraw.test.tsx, ReportViewer.overdraw.test.tsx) — converted to createTempDir without adding cleanup (preserves prior behaviour; if leak fixing is wanted that's a separate PR).
• Mid-test rmSync calls that simulate user-driven directory wipes (e.g. observability/logger.test.ts, ampli-config.test.ts .amplitude/ subdir) — left inline; only the temp-dir setup/teardown moved to the helper.

🤖 Generated with Claude Code

---

Note

Low Risk
Test-only refactor that standardizes temp directory creation/cleanup; low risk aside from potential test isolation/cleanup behavior differences if any call sites were relying on implicit rmSync semantics.

Overview
Completes the test-suite migration away from ad-hoc mkdtempSync/rmSync temp directory patterns to the shared createTempDir helper, updating setup/teardown across remaining CLI, command, lib, agent, middleware, orchestration, and TUI test files.

A few tests that previously used local makeTmpDir/cleanup(dir) helpers were updated to delegate to createTempDir (including a small cleanupByDir map in wizard-tools.test.ts) so existing call sites keep working while centralizing cleanup semantics.

^{Reviewed by Cursor Bugbot for commit 922b7ed. Bugbot is set up for automated code reviews on this repo. Configure here.}