feat: ?format= output option + output guidance#37
Merged
Conversation
- Pin libxsql v1.0.7 (brings ?format=text|csv|tsv on /query via the shared
thinclient; JSON stays default). idasql delegates to the thinclient, so no
handler logic change.
- Fix stale /help + agent-guide Response Format (flat {columns,rows} and a
wrong 'statements' key) to the real {results:[...]} envelope; document format=.
- Add output guidance to the agent guide: Selection (decide display by intent),
Fidelity (show real artifacts), Mechanics (consume the JSON envelope, don't
pipe through python/jq to reformat).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports two cross-tool improvements from bnsql (all three tools share libxsql).
Feature:
?format=text|csv|tsvon /queryPins libxsql v1.0.7, which adds
format=in the shared thinclienthttp_query_server. idasql delegates to the thinclient, so no handler logic change — JSON stays default; text/csv/tsv are for terminal/pipe use./help+ README updated.Also corrects the stale Response Format in
/helpand the agent guide — they showed a flat{columns,rows}shape and a wrongstatementskey; fixed to the real{results:[...]}envelope.Guidance
prompts/idasql_agent.mdgains an Output guidance section: Selection (decide display by intent), Fidelity (show the real artifact, not a paraphrase), Mechanics (consume the JSON envelope; don't pipe through python/jq to pre-render a table). Mirrors the bnsql guide fix; cross-tool lessons inbnsql-insights.md.Build note
xsql(v1.0.7) andidasql_cli(contains the editedhttp_server.cpp+ thinclient) build and link cleanly. format= behavior verified live against the identical shared thinclient via ghidrasql. Theidasql_plugintarget has a pre-existing, unrelatedbookmarks_tSDK-compat error (inida_compat.hpp, untouched here).