-
Notifications
You must be signed in to change notification settings - Fork 45
enhance: improve dependency source resolution #282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
suxiaogang223
wants to merge
3
commits into
alibaba:main
Choose a base branch
from
suxiaogang223:codex/fix-dependency-resolution
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| # Copyright 2026-present Alibaba Inc. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| function(paimon_find_target_headers OUT_VAR TARGET_NAME) | ||
| set(options NO_DEFAULT_PATH) | ||
| set(one_value_args) | ||
| set(multi_value_args NAMES HINTS PATH_SUFFIXES) | ||
| cmake_parse_arguments(ARG | ||
| "${options}" | ||
| "${one_value_args}" | ||
| "${multi_value_args}" | ||
| ${ARGN}) | ||
|
|
||
| if(NOT TARGET ${TARGET_NAME} OR NOT ARG_NAMES) | ||
| set(${OUT_VAR} | ||
| "${OUT_VAR}-NOTFOUND" | ||
| PARENT_SCOPE) | ||
| return() | ||
| endif() | ||
|
|
||
| set(_target_include_dirs) | ||
| foreach(_property INTERFACE_INCLUDE_DIRECTORIES INTERFACE_SYSTEM_INCLUDE_DIRECTORIES | ||
| INCLUDE_DIRECTORIES) | ||
| get_target_property(_property_value ${TARGET_NAME} ${_property}) | ||
| if(_property_value AND NOT _property_value MATCHES "-NOTFOUND$") | ||
| list(APPEND _target_include_dirs ${_property_value}) | ||
| endif() | ||
| endforeach() | ||
|
|
||
| set(_search_dirs) | ||
| foreach(_dir IN LISTS _target_include_dirs) | ||
| if(_dir MATCHES "^\\$<BUILD_INTERFACE:(.*)>$") | ||
| list(APPEND _search_dirs "${CMAKE_MATCH_1}") | ||
| elseif(_dir MATCHES "^\\$<INSTALL_INTERFACE:(.*)>$") | ||
| if(IS_ABSOLUTE "${CMAKE_MATCH_1}") | ||
| list(APPEND _search_dirs "${CMAKE_MATCH_1}") | ||
| endif() | ||
| elseif(NOT _dir MATCHES "^\\$<") | ||
| list(APPEND _search_dirs "${_dir}") | ||
| endif() | ||
| endforeach() | ||
|
|
||
| list(APPEND _search_dirs ${ARG_HINTS}) | ||
| if(_search_dirs) | ||
| list(REMOVE_DUPLICATES _search_dirs) | ||
| endif() | ||
|
|
||
| string(MAKE_C_IDENTIFIER "${TARGET_NAME}_${ARG_NAMES}" _header_var_suffix) | ||
| set(_header_dir_var "PAIMON_${_header_var_suffix}_HEADER_DIR") | ||
| set(_find_args NAMES ${ARG_NAMES}) | ||
| if(_search_dirs) | ||
| list(APPEND _find_args HINTS ${_search_dirs}) | ||
| endif() | ||
| if(ARG_PATH_SUFFIXES) | ||
| list(APPEND _find_args PATH_SUFFIXES ${ARG_PATH_SUFFIXES}) | ||
| endif() | ||
| list(APPEND _find_args NO_DEFAULT_PATH) | ||
|
|
||
| unset(${_header_dir_var} CACHE) | ||
| find_path(${_header_dir_var} ${_find_args}) | ||
|
|
||
| if(NOT ${_header_dir_var}) | ||
| get_property(_partial_targets GLOBAL PROPERTY PAIMON_PARTIAL_SYSTEM_TARGETS) | ||
| list(APPEND _partial_targets "${TARGET_NAME}: ${ARG_NAMES}") | ||
| set_property(GLOBAL PROPERTY PAIMON_PARTIAL_SYSTEM_TARGETS "${_partial_targets}") | ||
| endif() | ||
|
|
||
| set(${OUT_VAR} | ||
| "${${_header_dir_var}}" | ||
| PARENT_SCOPE) | ||
|
|
||
| unset(${_header_dir_var} CACHE) | ||
| unset(_find_args) | ||
| unset(_header_dir_var) | ||
| unset(_header_var_suffix) | ||
| unset(_partial_targets) | ||
| unset(_property_value) | ||
| unset(_search_dirs) | ||
| unset(_target_include_dirs) | ||
| endfunction() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.