Open
Conversation
Two recent release tags (v0.33.0-rc.54.algolia.1 and v0.34.2-algolia.1) shipped with zero binary assets, making the GitHub /releases/latest response resolve to a tag that install.sh cannot download (404). The CD workflow also never fired for these because it only triggered on develop and master, but our default branch is main. - cd.yml: add main to the push-trigger branch list so release-please and build-release run automatically on this fork. - release.yml: after Upload Release Assets, verify every required binary and checksums.txt actually landed on the tag, and smoke-test the Linux musl tarball end-to-end by downloading it and running rtk --version. Either check failing now fails the workflow, surfacing the regression at release time instead of in user terminals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two recent release tags (
v0.33.0-rc.54.algolia.1,v0.34.2-algolia.1) shipped with zero binary assets, so GitHub's/releases/latestpoints at a tag whose.tar.gzdownloads 404. A colleague just hit this via the documentedcurl | shinstall.Root cause, twofold:
cd.ymltriggers on[develop, master], but our default branch ismain. Release-please → build-release never ran.gh release create(or a partial run) can leave a tag with zero assets, and nothing catches it.Changes
cd.yml: addmainto the push-trigger branch list, and wire therelease-please+ pre-release dispatch guards to treatmainas the stable lane.release.yml: add two steps after Upload Release Assets:checksums.txtis present on the tag; fail otherwise with a clear error.rtk --version. Uses the tag (not/releases/latest) so prereleases are covered.With these, a release where any builder silently dropped its artifact fails the workflow instead of landing broken.
Test plan
develop, confirm the verify + smoke steps execute and pass.