feat(apikeys): list keys with the signed-in session - #274
Closed
LorrisSaintGenez wants to merge 7 commits into
Closed
feat(apikeys): list keys with the signed-in session#274LorrisSaintGenez wants to merge 7 commits into
LorrisSaintGenez wants to merge 7 commits into
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 22 |
| Duplication | 137 |
TIP This summary will be updated as you push new changes.
LorrisSaintGenez
requested review from
a team,
dylantientcheu and
levimichael
and removed request for
a team
July 27, 2026 18:27
LorrisSaintGenez
marked this pull request as ready for review
July 27, 2026 18:30
LorrisSaintGenez
force-pushed
the
feat/api-keys-search-get-create
branch
from
July 27, 2026 19:42
c940e41 to
6de9ed3
Compare
LorrisSaintGenez
force-pushed
the
feat/apikeys-list-session
branch
from
July 27, 2026 19:42
80b5264 to
e7e3125
Compare
LorrisSaintGenez
force-pushed
the
feat/api-keys-search-get-create
branch
from
July 27, 2026 19:53
6de9ed3 to
557d2e4
Compare
LorrisSaintGenez
force-pushed
the
feat/apikeys-list-session
branch
5 times, most recently
from
July 27, 2026 21:32
d0d5420 to
452f111
Compare
dylantientcheu
approved these changes
Jul 28, 2026
Contributor
Author
|
@dylantientcheu Didn't want the PR to get too big, and planned on doing a follow-up PR, but will restore them |
LorrisSaintGenez
force-pushed
the
feat/apikeys-list-session
branch
from
July 28, 2026 17:44
452f111 to
f22247b
Compare
dylantientcheu
approved these changes
Jul 28, 2026
Contributor
Author
|
Not needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
algolia apikeys listno longer requires an admin API key: being signed in with an application selected is enough.--api-key,--admin-api-key,ALGOLIA_API_KEYorALGOLIA_ADMIN_API_KEYis set, which still lists every key of the application.acls: adminannotation that made the command unreachable for a signed-in user.Profile.HasExplicitAPIKey(), shared withapikeys create. It now also coversALGOLIA_ADMIN_API_KEY, which the create-side helper was missing.The two paths don't return the same set. The Public API only knows the keys created through the dashboard or the CLI, so the session path lists those; the Search API lists every key of the engine. The session path also reports no expiry — the Public API serializer hardcodes
validitytonil— soVALIDITYshows-there.Table rendering is now shared by both paths, which fixes a column shift: a key with no description used to render one field short, misaligning every following column.
Requires algolia/AlgoliaWeb#29489 to be deployed. Stacked on #273.
Test
Sign in first, with an application selected:
List the keys of the current application:
Expect one row per key created by the CLI, with
VALIDITYat-. Create one and list again to see it appear:Structured output:
Expect an array of objects carrying
uuid,value,acl,indexes,referersandcreated_at.Error paths:
Expect
application devDOESNOTEXIST doesn't exist, or your account doesn't have access to it, then a403followed byThis API key isn't an admin key.Admin key path still lists everything, including keys created outside the CLI:
GROUT-438