Skip to content

Issue72 Deprecate Add<T> method in favor of Set<T>#136

Open
matthew-p wants to merge 6 commits into
alastairtree:masterfrom
matthew-p:issue-72-set-method
Open

Issue72 Deprecate Add<T> method in favor of Set<T>#136
matthew-p wants to merge 6 commits into
alastairtree:masterfrom
matthew-p:issue-72-set-method

Conversation

@matthew-p

@matthew-p matthew-p commented Sep 27, 2020

Copy link
Copy Markdown

An attempt to address issue # 72, deprecating the IAppCache.Add(...) method with a .Set() method

Replaces the functionality as-is, adds [Obsolete] attributes to the Add method, and a unit test to confirm that all classes implementing IAppCache have an Obsolete attribute on their Add method

#72

@alastairtree alastairtree left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you. Will leave this here until i have setup a branch for the 3.0 changes. Thanks!

@alastairtree alastairtree added this to the 3.0 milestone Sep 27, 2020
@jnyrup

jnyrup commented Sep 27, 2020

Copy link
Copy Markdown
Contributor

Tip:
To prevent IntelliSense from suggestion both Set and Add you can add [EditorBrowsable(EditorBrowsableState.Never)] to the obsolete methods.

@alastairtree

Copy link
Copy Markdown
Owner

Tip:
To prevent IntelliSense from suggestion both Set and Add you can add [EditorBrowsable(EditorBrowsableState.Never)] to the obsolete methods.

Did not know that, very useful! Let's use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants