Skip to content

Conversation

@Vizonex
Copy link

@Vizonex Vizonex commented Nov 18, 2025

What do these changes do?

These Changes to sort-all allow effective recursions through multiple directories via the use of wildcards

example:

sort-all src/* 

Would sort all files in src/* that end with .py, .pxd, .pyx, .pyi files allowing for lazier sorting to take place.

Are there changes in behavior for the user?

There is now a way to lazily sort multiple modules with the use of sort-all

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 76.02%. Comparing base (261cbc4) to head (cd4bdef).

Files with missing lines Patch % Lines
sort_all.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage   75.69%   76.02%   +0.33%     
==========================================
  Files           1        1              
  Lines         144      146       +2     
==========================================
+ Hits          109      111       +2     
  Misses         35       35              
Flag Coverage Δ
unit 76.02% <66.66%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@webknjaz
Copy link
Member

Technically, this should already work because shells would expand the args before calling the script. But if it's quoted like sort-all 'src/*' to prevent expansion, then it might be useful. The downside would be being unable to reference files called '*'.

Whats the environment where this doesn't already work for you? Do you have logs/examples?

@webknjaz
Copy link
Member

Additionally, this should just use pathlib.Path.glob().

@Vizonex
Copy link
Author

Vizonex commented Nov 19, 2025

Whats the environment where this doesn't already work for you? Do you have logs/examples?

Windows mainly. I work with a windows 10 desktop for most of my projects including some that are windows only such as

  • wepoll
  • winloop
    Wildcard resolution would work on ubuntu or linux under what you have told me maybe but I don't see this implementation working on windows hence this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants