Skip to content

Conversation

@musicinmybrain
Copy link
Contributor

@musicinmybrain musicinmybrain commented Nov 25, 2025

What do these changes do?

Fixes a regression in TestFrozenList.test_iface since Python 3.15.0a2, discovered in preliminary downstream integration testing in Fedora (https://bugzilla.redhat.com/show_bug.cgi?id=2416992), due to hidden internal __annotate_func__ and __annotations_cache__ keys added to the class dict in python/cpython#132345.

This PR simply adds them to the SKIP_METHODS for TestFrozenList.test_iface, indicating that they aren’t part of the interface we need to provide.

Are there changes in behavior for the user?

No, this is only a testing change.

Related issue number

N/A

Checklist

  • I think the code is well written
  • Unit tests for the changes exist This fixes a test regression
  • Documentation reflects the changes Nothing new to document
  • If you provide code modifications, please add yourself to CONTRIBUTORS.txt I think that this is not needed for such a trivial change.
  • Add a new news fragment into the CHANGES folder

@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.91%. Comparing base (ba37a4d) to head (d8a1c9e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #723      +/-   ##
==========================================
+ Coverage   94.90%   94.91%   +0.01%     
==========================================
  Files          10       10              
  Lines         726      728       +2     
  Branches       48       48              
==========================================
+ Hits          689      691       +2     
  Misses         13       13              
  Partials       24       24              
Flag Coverage Δ
CI-GHA 94.78% <100.00%> (+0.01%) ⬆️
MyPy 65.27% <100.00%> (+0.10%) ⬆️
OS-Linux 99.70% <ø> (ø)
OS-Windows 99.70% <ø> (ø)
OS-macOS 99.70% <ø> (ø)
Py-3.10.11 99.70% <ø> (ø)
Py-3.10.19 99.70% <ø> (ø)
Py-3.11.14 99.70% <ø> (ø)
Py-3.11.9 99.70% <ø> (ø)
Py-3.12.10 99.70% <ø> (ø)
Py-3.12.12 99.70% <ø> (ø)
Py-3.13.8 99.70% <ø> (ø)
Py-3.13.9 99.70% <ø> (ø)
Py-3.13.9t 99.70% <ø> (ø)
Py-3.14.0 99.70% <ø> (ø)
Py-3.14.0t 99.70% <ø> (ø)
Py-3.9.13 99.70% <ø> (ø)
Py-3.9.24 ?
Py-3.9.25 99.70% <ø> (ø)
Py-pypy3.10.16-7.3.19 98.81% <ø> (ø)
Py-pypy3.9.19-7.3.16 98.81% <ø> (ø)
VM-macos-latest 99.70% <ø> (ø)
VM-ubuntu-latest 99.70% <ø> (ø)
VM-windows-11-arm 99.70% <ø> (ø)
VM-windows-latest 99.70% <ø> (ø)
pytest 99.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

"__slots__",
"__static_attributes__",
"__firstlineno__",
# Since Python 3.15.0a2: https://github.com/python/cpython/pull/132345
Copy link

@stefanor stefanor Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was backported to 3.14.0, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants