Skip to content

Bug fixes for the reply engine - #412

Closed
LilOleByte wants to merge 1 commit into
aichaos:masterfrom
LilOleByte:fix/reply-engine
Closed

Bug fixes for the reply engine#412
LilOleByte wants to merge 1 commit into
aichaos:masterfrom
LilOleByte:fix/reply-engine

Conversation

@LilOleByte

Copy link
Copy Markdown

Bug fixes for the reply engine.

  • Escape user/bot/array/history values used inside trigger patterns
  • Stop crashes when a number uservar appears in a trigger
  • Cap {weight} at 10000 so huge weights cannot blow memory
  • Format @ and {@} redirects like normal user messages
  • Fix missing await, trigger sorting by length, %Previous topic lookup, case-sensitive matching, and trigger history on redirects
  • Stop double-processing tags after BEGIN {ok}
  • Keep the full value after the first = in <set> / math tags; <set name> with no = does nothing
  • Leave the message alone if sortReplies() was not called yet
  • Fix a few global-regex and stringFormat edge cases
  • New option: enableObjectMacros (default true)

While making a rivescript-rb interpreter i found quite a few problems that have been here inside the existing code base for quite some time.

I have been using the telnet version for years and i noticed i had never submitted any fixes to the main repo until i decided to make write one in ruby as javascript is a pain compared to ruby,

Bug fixes for the reply engine.

- Escape user/bot/array/history values used inside trigger patterns
- Stop crashes when a number uservar appears in a trigger
- Cap `{weight}` at 10000 so huge weights cannot blow memory
- Format `@` and `{@}` redirects like normal user messages
- Fix missing `await`, trigger sorting by length, `%Previous` topic
  lookup, case-sensitive matching, and trigger history on redirects
- Stop double-processing tags after BEGIN `{ok}`
- Keep the full value after the first `=` in `<set>` / math tags;
  `<set name>` with no `=` does nothing
- Leave the message alone if `sortReplies()` was not called yet
- Fix a few global-regex and `stringFormat` edge cases
- New option: `enableObjectMacros` (default `true`)
@kirsle
kirsle self-requested a review August 6, 2026 18:07
@kirsle kirsle self-assigned this Aug 6, 2026
@LilOleByte

Copy link
Copy Markdown
Author

Yeah i had forgotten to upload the test just saw the notification. I am sorry about that been pretty busy, and programming is no longer my full time job. its been Harder to keep a full time job even as a senior developer at least where i am located.

@LilOleByte LilOleByte closed this Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants