Bug fixes for the reply engine - #412
Closed
LilOleByte wants to merge 1 commit into
Closed
Conversation
Bug fixes for the reply engine.
- Escape user/bot/array/history values used inside trigger patterns
- Stop crashes when a number uservar appears in a trigger
- Cap `{weight}` at 10000 so huge weights cannot blow memory
- Format `@` and `{@}` redirects like normal user messages
- Fix missing `await`, trigger sorting by length, `%Previous` topic
lookup, case-sensitive matching, and trigger history on redirects
- Stop double-processing tags after BEGIN `{ok}`
- Keep the full value after the first `=` in `<set>` / math tags;
`<set name>` with no `=` does nothing
- Leave the message alone if `sortReplies()` was not called yet
- Fix a few global-regex and `stringFormat` edge cases
- New option: `enableObjectMacros` (default `true`)
kirsle
self-requested a review
August 6, 2026 18:07
Author
|
Yeah i had forgotten to upload the test just saw the notification. I am sorry about that been pretty busy, and programming is no longer my full time job. its been Harder to keep a full time job even as a senior developer at least where i am located. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fixes for the reply engine.
{weight}at 10000 so huge weights cannot blow memory@and{@}redirects like normal user messagesawait, trigger sorting by length,%Previoustopic lookup, case-sensitive matching, and trigger history on redirects{ok}=in<set>/ math tags;<set name>with no=does nothingsortReplies()was not called yetstringFormatedge casesenableObjectMacros(defaulttrue)While making a rivescript-rb interpreter i found quite a few problems that have been here inside the existing code base for quite some time.
I have been using the telnet version for years and i noticed i had never submitted any fixes to the main repo until i decided to make write one in ruby as javascript is a pain compared to ruby,