fix(security): require MNEMONIC env var, remove hardcoded default#247
Open
JackBinswitch-btc wants to merge 1 commit intoaibtcdev:mainfrom
Open
fix(security): require MNEMONIC env var, remove hardcoded default#247JackBinswitch-btc wants to merge 1 commit intoaibtcdev:mainfrom
JackBinswitch-btc wants to merge 1 commit intoaibtcdev:mainfrom
Conversation
Require MNEMONIC env var instead of silently falling back to a publicly-known default mnemonic. Closes aibtcdev#245. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DEFAULT_CONFIGinsrc/utilities.tsMNEMONICenvironment variable to be set, throwing a clear error if missingWhat changed
In
src/utilities.ts:DEFAULT_CONFIG.MNEMONICchanged from the hardcoded testnet mnemonic"crater office wreck aunt lumber casino veteran mixed float arrive lens final"to an empty string"".loadConfig()MNEMONIC resolution changed from:to:
This ensures that if
MNEMONICis not set in the environment, the application fails fast with a descriptive error instead of silently using a publicly-known key.Test plan
MNEMONICenv var setMNEMONICis not setMNEMONICprovided via.envCloses #245.
🤖 Generated with Claude Code