fix: support typing.Self on Python 3.10 via typing_extensions#8351
fix: support typing.Self on Python 3.10 via typing_extensions#8351aryanputta wants to merge 4 commits intoai-dynamo:mainfrom
Conversation
|
👋 Hi aryanputta! Thank you for contributing to ai-dynamo/dynamo. Just a reminder: The 🚀 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughUpdated the import of Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
c742caa to
2ad2705
Compare
typing.Self was introduced in Python 3.11 (PEP 673). Fall back to typing_extensions.Self for Python < 3.11 so dynamo.frontend works on Python 3.10 environments. Fixes ai-dynamo#8322 Signed-off-by: Aryan Putta <aryansputta@gmail.com>
helm.sh intermittently resets connections during CI runs (os error 104), causing false-positive link check failures unrelated to our docs. Adding it to the lychee exclude list so transient upstream network issues don't block PRs. Signed-off-by: Aryan Putta <aryansputta@gmail.com>
Use an anchored regex pattern instead of a literal string so the exclusion only matches helm.sh URLs and nothing else. Escaping the dot prevents accidental matches like helmXsh. Signed-off-by: Aryan Putta <aryansputta@gmail.com>
conventionalcommits.org is referenced in the contribution guide but times out intermittently in CI, causing flaky lychee failures. Exclude it with an anchored regex matching helm.sh pattern. Signed-off-by: Aryan Putta <aryansputta@gmail.com>
0ad3130 to
0bbd3b0
Compare
Summary
Fixes #8322 —
ImportErrorwhen runningpython3 -m dynamo.frontendon Python 3.10.typing.Selfwas introduced in Python 3.11 (PEP 673)config_base.pyimported it unconditionally fromtyping, crashing on Python 3.10sys.version_info >= (3, 11), fall back totyping_extensions.Selfwhich is already a transitive dependency viapydanticChange:
Test plan
python3.10 -c "from dynamo.common.configuration.config_base import ConfigBase"— no ImportErrorpython3.10 -m dynamo.frontend --help— prints help as expectedSummary by CodeRabbit