add support for injection-window handling in pycbc_inspiral_fir#16
Closed
Kanchan-05 wants to merge 1 commit intoahnitz:firinspiral2from
Closed
add support for injection-window handling in pycbc_inspiral_fir#16Kanchan-05 wants to merge 1 commit intoahnitz:firinspiral2from
Kanchan-05 wants to merge 1 commit intoahnitz:firinspiral2from
Conversation
ahnitz
reviewed
Apr 13, 2026
Owner
ahnitz
left a comment
ahnitz
left a comment
There was a problem hiding this comment.
@Kanchan-05 I don't think this really does much. Note that the valid region is already passed the injection times and restricts based on those. What does this change?
Author
|
@ahnitz This just cuts down the number of triggers we save at the end when injections are present. Instead of storing everything, it only keeps triggers around the injection time, so it saves some memory for injection runs. |
Owner
|
@Kanchan-05 How is that not already being done? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for handling injection-window in pycbc_inspiral_fir
This PR adds support for proper handling of injection windows in pycbc_inspiral_fir. Currently, SNRs are computed and stored for all trigger times. With this modification, trigger information is restricted to a window around the injection time, consistent with pycbc_inspiral's behavior.