Address Copilot feedback from a previous PR#306
Merged
Conversation
This is also likely more performant than a regex but ¯\_(ツ)_/¯
Merged
There was a problem hiding this comment.
Pull request overview
This PR updates the quad-word replacement logic to avoid unintended regex behavior, and aligns the PR workflow’s Node.js version with the repository’s pinned Node version file.
Changes:
- Replace quad-word substitution from a global
RegExp-based replace to a safer literal-string replacement. - Update GitHub Actions PR workflow to use
.node-versionvianode-version-file.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
index.ts |
Avoids regex-based replacement pitfalls by using a literal split/join and short-circuiting when quadWord is missing. |
.github/workflows/pull_request.yml |
Pins CI Node.js version to the repo’s .node-version file for consistent local/CI parity. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
acneville
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.