Wpdual smt declarations#133
Merged
mira-alford merged 8 commits intomainfrom Apr 22, 2026
Merged
Conversation
* move out linear functions * i think it works but it is slow * probably works (not slow) (could be very wrong) * Transform * comment * Better simplification * Fix copyprop collapsing (now to do the linear version... terrifying...) * fix linear copy propagation * It does copy prop faithfully! * Make copied_from not store edges (they were always id) * cleanup * remove old copy prop * Interproc correctly * Stubs * idk * doc * tracing * Bigger test * comment * bigger test... * test * push test oops * propagate bools through call in test * remove todo that is done * Handle id leaves cycles correctly + exit stubs go to bottom * skip empty procedures --------- Co-authored-: Mira-Alford <mira.alford@proton.me>
JTrenerry
reviewed
Apr 22, 2026
JTrenerry
reviewed
Apr 22, 2026
JTrenerry
requested changes
Apr 22, 2026
JTrenerry
approved these changes
Apr 22, 2026
Collaborator
JTrenerry
left a comment
JTrenerry
left a comment
There was a problem hiding this comment.
LGTM, but I have no clue smt
Collaborator
Author
|
Kait says lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added program declarations to the generated smt for redundancy check in wpdual.
Required some tweaks to expr_smt. I suspect there are quite a few remaining expressions that aren't per the smt spec but this gets my memory encoding working.
Unfortunately this hardcodes in an expectation that we are using cvc5 due to datatype field updates. That's a later problem though 😅