feat: snap SVG dimensions to terminal character grid#7
Open
xav-ie wants to merge 1 commit intoagentstation:mainfrom
Open
feat: snap SVG dimensions to terminal character grid#7xav-ie wants to merge 1 commit intoagentstation:mainfrom
xav-ie wants to merge 1 commit intoagentstation:mainfrom
Conversation
Use TermCols/TermRows from xterm.js to snap the inner SVG viewport to the exact character grid, eliminating black bars and subpixel gaps. Set background color on the outer <svg> element to prevent edge rendering artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cols × charWidthandrows × charHeightusingmath.Roundto eliminate sub-pixel gaps between terminal content and the SVG edgeContext
The SVG viewport was previously sized from the style config, which doesn't always align to the character grid. This left fractional-pixel gaps at content edges. Snapping to the grid and rounding to the nearest integer minimizes these gaps.
Test plan
go test ./...)