Skip to content

fix(ReActAgent): allow tool calls to reach acting phase for proper er… #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LearningGp merged 3 commits into from
Mar 4, 2026
Merged

fix(ReActAgent): allow tool calls to reach acting phase for proper er… #850

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a41caf0
fix(ReActAgent): allow tool calls to reach acting phase for proper er…
luoxiner Mar 2, 2026
d6f9d37
Merge branch 'main' into main
LearningGp Mar 4, 2026
158f2fd
Merge branch 'main' into main
LearningGp Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions agentscope-core/src/main/java/io/agentscope/core/ReActAgent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -750,12 +750,9 @@ private boolean isFinished(Msg msg) {
List<ToolUseBlock> toolCalls = msg.getContentBlocks(ToolUseBlock.class);

// No tool calls - finished
if (toolCalls.isEmpty()) {
return true;
}

// Has tool calls but none are in toolkit - finished
return toolCalls.stream().noneMatch(tc -> toolkit.getTool(tc.getName()) != null);
// If there are tool calls (even non-existent ones), continue to acting phase
// where ToolExecutor will return "Tool not found" error for the model to see
return toolCalls.isEmpty();
}

/**
Expand Down
Loading