fix: bound response reads in preset catalog and download (import of github/spec-kit#3778) - #109
Open
one-kash wants to merge 4 commits into
Open
fix: bound response reads in preset catalog and download (import of github/spec-kit#3778)#109one-kash wants to merge 4 commits into
one-kash wants to merge 4 commits into
Conversation
Replace unbounded response.read() calls with read_response_limited() in presets/__init__.py to prevent DoS via oversized catalog or preset archive responses. Three call sites fixed: - _fetch_single_catalog JSON read (catalog metadata) - _fetch_catalog JSON read (legacy path) - download_preset ZIP read (binary download)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imported from upstream PR github#3778
Original author: @Quratulain-bilal
Original head branch:
fix/unbounded-presets-catalog-readSummary
Replace unbounded
esponse.read()\ calls with
ead_response_limited()\ in \presets/init.py\ to prevent DoS via oversized catalog or preset archive responses.
Changes
Three call sites fixed:
Added \ rom .._download_security import MAX_DOWNLOAD_BYTES, MAX_JSON_METADATA_BYTES, read_response_limited.