Skip to content

fix: sync lockfile to match bumped package.json (#68)#70

Merged
frontegg-david merged 1 commit into
mainfrom
cherry-pick-pr-68
Jun 19, 2026
Merged

fix: sync lockfile to match bumped package.json (#68)#70
frontegg-david merged 1 commit into
mainfrom
cherry-pick-pr-68

Conversation

@alexmercerpo

@alexmercerpo alexmercerpo commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

Cherry-picked from #63 (merged to release/2.14.x)
Original commit: 898a1b5

  • fix: sync lockfile to match bumped package.json versions in release workflows

  • fix: update publish-release.yml for mutable dependency installation and sync package versions in yarn.lock

  • fix: resolve core lint error and prettier formatting

  • Declare @types/estree in libs/core dependencies (matches libs/ast). The interpreter/interpreter-adapter import estree types, which the @nx/dependency-checks rule requires to be declared — this was the only lint error (the remaining 11 are non-blocking warnings).
  • Run prettier --write on the 6 files flagged by prettier --check.

Summary by CodeRabbit

  • Dependencies

    • Added @types/estree v1.0.8 to improve type definitions in core package.
  • Chores

    • Enhanced release workflow to better handle dependency drift during publishing.
    • Reformatted security documentation structure for improved clarity.
  • Style

    • Refined code formatting across test and core adapter files.

* Cherry-pick: feat: add additional entry points for worker script in project configuration (#64)

Cherry-picked from #63 (merged to release/2.14.x)
Original commit: 898a1b5

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: alexmercerpo <251740932+alexmercerpo@users.noreply.github.com>

* fix: sync lockfile to match bumped package.json versions in release workflows

* fix: update publish-release.yml for mutable dependency installation and sync package versions in yarn.lock

* fix: resolve core lint error and prettier formatting

- Declare @types/estree in libs/core dependencies (matches libs/ast). The
  interpreter/interpreter-adapter import `estree` types, which the
  @nx/dependency-checks rule requires to be declared — this was the only
  lint error (the remaining 11 are non-blocking warnings).
- Run prettier --write on the 6 files flagged by `prettier --check`.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: alexmercerpo <251740932+alexmercerpo@users.noreply.github.com>
Co-authored-by: David Antoon <davidmantoon@gmail.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d4ae97e7-3611-42e7-bb36-4216ff30c741

📥 Commits

Reviewing files that changed from the base of the PR and between 4177a09 and a3ab6e3.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (8)
  • .github/workflows/publish-release.yml
  • SECURITY.md
  • libs/core/package.json
  • libs/core/src/__tests__/interpreter-transform-integration.spec.ts
  • libs/core/src/adapters/__tests__/interpreter-adapter.spec.ts
  • libs/core/src/adapters/interpreter-adapter.ts
  • libs/core/src/interpreter/interpreter.ts
  • libs/core/src/worker.ts

📝 Walkthrough

Walkthrough

The publish-release CI workflow gains an explicit yarn install --no-immutable step to fix lockfile drift after version bumps. @types/estree is added to libs/core dependencies. Several source files receive cosmetic reformatting of function signatures and expressions with no behavioral changes. SECURITY.md receives minor spacing fixes.

Changes

Publish workflow fix and formatting cleanup

Layer / File(s) Summary
Publish workflow: mutable yarn install for lockfile drift
.github/workflows/publish-release.yml
install: "false" is set on the Setup Node + Yarn action and a new "Install dependencies" step runs yarn install --no-immutable to self-heal yarn.lock drift after version bumps.
@types/estree dependency and source/doc formatting
libs/core/package.json, libs/core/src/worker.ts, libs/core/src/adapters/interpreter-adapter.ts, libs/core/src/interpreter/interpreter.ts, libs/core/src/__tests__/..., libs/core/src/adapters/__tests__/..., SECURITY.md
Adds @types/estree@1.0.8 to libs/core dependencies. Reformats export type block in worker.ts to single-line, reformats timer assignment in interpreter-adapter.ts, reformats evalExpr signature and produced ternary in interpreter.ts, and reformats makeContext signatures in test helpers. SECURITY.md Scope section receives blank-line spacing fixes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

Poem

A rabbit once tripped on a lock that had drifted,
The yarn tangled up and the CI had shifted.
So now with --no-immutable we mend what once broke,
And format our code with a neat little stroke.
🐇 The warren is tidy, the pipeline runs free! ✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cherry-pick-pr-68

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@frontegg-david frontegg-david merged commit 86d3990 into main Jun 19, 2026
7 of 8 checks passed
@frontegg-david frontegg-david deleted the cherry-pick-pr-68 branch June 19, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants