fix(session): recreate query when configured skills change - #968
Open
ran411285752 wants to merge 2 commits into
Open
fix(session): recreate query when configured skills change#968ran411285752 wants to merge 2 commits into
ran411285752 wants to merge 2 commits into
Conversation
Why: Resumed sessions reused a Query created with stale skills. What: Normalize and fingerprint skills while preserving SDK semantics; add lifecycle regressions. Impact: Skill changes now recreate the Query under the same session ID without fingerprinting unrelated options. Refs: agentclientprotocol#955
Why: The lifecycle regression only proved teardown and a recreation attempt. What: Exercise newSession through resumeSession and assert the SDK receives the replacement skills. Impact: The PR now covers a successful Query replacement while preserving the native session ID. Refs: agentclientprotocol#955
Contributor
Author
|
@benbrandt, could you review this when you have a chance? This extends the resumed-session fingerprint logic you introduced in #515 to include normalized Claude SDK The CI and Conventional PRs workflows are currently awaiting maintainer approval for this external-fork contribution. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skillsin the resumed-session fingerprint'all', empty, and explicit skill selections_meta.claudeCode.optionsfields out of the fingerprintTesting
npm run buildnpm run lintnpx prettier --check src/acp-agent.ts src/tests/acp-agent.test.ts src/tests/create-session-options.test.tsnewSession(['pdf']) -> resumeSession(['docx'])Closes #955