Skip to content

fix(schema): Add missing titles for enum variants in schema #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benbrandt merged 1 commit into from
Jan 15, 2026
+457 −117
Merged

fix(schema): Add missing titles for enum variants in schema #384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions docs/protocol/draft/schema.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1629,7 +1629,7 @@ The input specification for a command.

**Type:** Union

<ResponseField name="Variant">
<ResponseField name="unstructured">
All text that was typed after the command name is provided as input.

<Expandable title="Properties">
Expand Down Expand Up @@ -2180,7 +2180,7 @@ because of resource constraints or shutdown.
**Resource not found**: A given resource, such as a file, was not found.
</ResponseField>

<ResponseField name="integer" type="int32">
<ResponseField name="Other" type="int32">
Other undefined error code.
</ResponseField>

Expand Down Expand Up @@ -2422,7 +2422,7 @@ See protocol docs: [Extensibility](https://agentclientprotocol.com/protocol/exte
</Expandable>
</ResponseField>

<ResponseField name="Variant">
<ResponseField name="stdio">
Stdio transport configuration

All Agents MUST support this transport.
Expand Down Expand Up @@ -2815,11 +2815,11 @@ The Server MUST reply with the same value in the Response object if included. Th
{""}
</ResponseField>

<ResponseField name="integer" type="int64">
<ResponseField name="Number" type="int64">
{""}
</ResponseField>

<ResponseField name="string" type="string">
<ResponseField name="Str" type="string">
{""}
</ResponseField>

Expand Down Expand Up @@ -3062,7 +3062,7 @@ Category names that do not begin with `_` are reserved for the ACP spec.
Thought/reasoning level selector.
</ResponseField>

<ResponseField name="string" type="string">
<ResponseField name="other" type="string">
Unknown / uncategorized selector.
</ResponseField>

Expand Down Expand Up @@ -3163,11 +3163,11 @@ Possible values for a session configuration option.

**Type:** Union

<ResponseField name="array" type="array">
<ResponseField name="Ungrouped" type="array">
A flat list of options with no grouping.
</ResponseField>

<ResponseField name="array" type="array">
<ResponseField name="Grouped" type="array">
A list of options grouped under headers.
</ResponseField>

Expand Down
10 changes: 5 additions & 5 deletions docs/protocol/schema.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1159,7 +1159,7 @@ The input specification for a command.

**Type:** Union

<ResponseField name="Variant">
<ResponseField name="unstructured">
All text that was typed after the command name is provided as input.

<Expandable title="Properties">
Expand Down Expand Up @@ -1676,7 +1676,7 @@ and use the reserved range (-32000 to -32099) for protocol-specific errors.
**Resource not found**: A given resource, such as a file, was not found.
</ResponseField>

<ResponseField name="integer" type="int32">
<ResponseField name="Other" type="int32">
Other undefined error code.
</ResponseField>

Expand Down Expand Up @@ -1918,7 +1918,7 @@ See protocol docs: [Extensibility](https://agentclientprotocol.com/protocol/exte
</Expandable>
</ResponseField>

<ResponseField name="Variant">
<ResponseField name="stdio">
Stdio transport configuration

All Agents MUST support this transport.
Expand Down Expand Up @@ -2271,11 +2271,11 @@ The Server MUST reply with the same value in the Response object if included. Th
{""}
</ResponseField>

<ResponseField name="integer" type="int64">
<ResponseField name="Number" type="int64">
{""}
</ResponseField>

<ResponseField name="string" type="string">
<ResponseField name="Str" type="string">
{""}
</ResponseField>

Expand Down
Loading