Refonte - Trésorerie > Journal > Ajout/Edition #2108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgreb
force-pushed
the
refacto/accounting-journal-add-edit
branch
3 times, most recently
from
8d9992d to
d23e6d7
Compare
vgreb
requested review from
Mopolo and
stakovicz
and removed request for
stakovicz
Mopolo
reviewed
Jan 15, 2026
sources/AppBundle/Accounting/Model/Repository/EventRepository.php
Outdated
Show resolved
Hide resolved
sources/AppBundle/Accounting/Model/Repository/TransactionRepository.php
Outdated
Show resolved
Hide resolved
sources/AppBundle/Controller/Admin/Accounting/Journal/EditTransactionAction.php
Outdated
Show resolved
Hide resolved
vgreb
force-pushed
the
refacto/accounting-journal-add-edit
branch
2 times, most recently
from
e7d187e to
3efad79
Compare
Mopolo
reviewed
Jan 20, 2026
| <label class="three wide column"> | ||
| </label> | ||
| <div class="field seven wide column"> | ||
| <a href="#" id="apply-vat-5-5">Calculer le montant HT soumis à TVA 5,5% sur la base de l'intégralité du montant TTC</a> |
Contributor
There was a problem hiding this comment.
Ces boutons ne fonctionnent pas quand je checkout la branche. Au clic ça rajoute juste un # à l'url et remonte en haut de la page sans remplir le champ.
Je pense qu'il doit manquer l'inclusion d'un script dans cette nouvelle page.
Collaborator
Author
There was a problem hiding this comment.
Il manquait effectivement le javascript. je l'ai rajouté et adapté
vgreb
force-pushed
the
refacto/accounting-journal-add-edit
branch
from
3efad79 to
bd5dcf0
Compare
Mopolo
reviewed
Jan 21, 2026
Contributor
There was a problem hiding this comment.
C'est nécessaire d'avoir le .twig dans le nom du fichier ?
Et on n'a pas de linter pour le js mais est-ce que tu pourrais fixer l'indentation pour que ce soit un peu plus lisible 🙏
Collaborator
Author
There was a problem hiding this comment.
J'ai modifié l'indentation.
Concernant l'extension du fichier : \
- soit le le conserve en .js.twig pour mutualiser au maximum
- soit je le renomme en .js et devrais dupliquer les balises script dans les 2 templates add.html.twig et edit.html.twig pour éviter que les IDE remontent des erreurs de syntaxe.
vgreb
force-pushed
the
refacto/accounting-journal-add-edit
branch
from
bd5dcf0 to
64946ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2107