fix: rename _convert_X in TimesNet to avoid BaseClassifier collision#5
Merged
TonyBagnall merged 5 commits intoaeon-toolkit:mainfrom Mar 23, 2026
Merged
fix: rename _convert_X in TimesNet to avoid BaseClassifier collision#5TonyBagnall merged 5 commits intoaeon-toolkit:mainfrom
TonyBagnall merged 5 commits intoaeon-toolkit:mainfrom
Conversation
TonyBagnall
approved these changes
Mar 23, 2026
Contributor
TonyBagnall
left a comment
TonyBagnall
left a comment
There was a problem hiding this comment.
great thanks, this is all very experimental, not run it myself yet :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The wrapper’s _convert_X overrides BaseClassifier._convert_X, causing the base class to unexpectedly receive a tuple (data, mask) instead of an np.ndarray.
Result: This triggers a ValueError in _fit during the input validation check.
Fix: Renamed the wrapper's internal helper to _reshape_X to avoid overriding the aeon base method.
Checklist
results/schema.md.