feat(tabs): focusgroup navigation controller refactor#6493
Conversation
…e/spectrum-web-components into nikkimk/simple-selection-controller
…ate branch Split off to nikkimk/tabs-focusgroup-refactor: this branch keeps only SelectionController and its Tabs click/Enter-Space/selected-property integration. Tabs' arrow-key/Home/End navigation reverts to the hand-rolled implementation, and FocusgroupNavigationController's `reason` field addition (needed for that refactor, not for this one) reverts along with it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…to separate branch" This reverts commit 3a4351d.
|
Coverage Report for CI Build 29098714932Coverage remained the same at 96.257%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
📚 Branch Preview Links🔍 Gen1 Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
Description
Refactor of 2nd-gen swc-tabs to leverage live focusgroup navigation controller.
Motivation and context
Centralizing roving tabindex/arrow key navigation into a single controller for the components that use it.
Related issue(s)
Screenshots (if appropriate)
Author's checklist
Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
Descriptive Test Statement
Descriptive Test Statement
Device review
Accessibility testing checklist
Required: Complete each applicable item and document your testing steps (replace the placeholders with your component-specific instructions).
Keyboard (required — document steps below) — What to test for: Focus order is logical; Tab reaches the component and all interactive descendants; Enter/Space activate where appropriate; arrow keys work for tabs, menus, sliders, etc.; no focus traps; Escape dismisses when applicable; focus indicator is visible.
Screen reader (required — document steps below) — What to test for: Role and name are announced correctly; state changes (e.g. expanded, selected) are announced; labels and relationships are clear; no unnecessary or duplicate announcements.