chore(dropzone): test suites#6448
Conversation
|
📚 Branch Preview Links🔍 Gen1 Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
827c525 to
144aaeb
Compare
607abae to
26dc7e5
Compare
144aaeb to
7fd8372
Compare
26dc7e5 to
87928fd
Compare
a2bf987 to
b10a35e
Compare
15ada21 to
972adaa
Compare
b10a35e to
13cc926
Compare
972adaa to
a32b450
Compare
440d0d8 to
af0429e
Compare
aa81723 to
a764c2f
Compare
af0429e to
2a005c1
Compare
d79fa33 to
557ff9e
Compare
2a005c1 to
9adcecd
Compare
rise-erpelding
left a comment
There was a problem hiding this comment.
A couple of small suggestions!
Also, do you want to update the migration plan here to check off items related to testing?
Yes! Updated. ✨ |
rise-erpelding
left a comment
There was a problem hiding this comment.
This looks great!
64d5bf2 to
72a9855
Compare
5f0439f to
439a3ee
Compare
72a9855 to
1acb11b
Compare
439a3ee to
19eb783
Compare
1acb11b to
c672ab3
Compare
80fda76 to
a0ead09
Compare
c672ab3 to
50e1c55
Compare
a0ead09 to
06e8fcf
Compare
50e1c55 to
495b0c5
Compare
06e8fcf to
0f8a012
Compare
495b0c5 to
41822e2
Compare
0f8a012 to
1b9fe4e
Compare
41822e2 to
b1b8d64
Compare
Description
Adds Phase 6 test coverage for the 2nd-gen
<swc-dropzone>component migration. Two new files are introduced:test/dropzone.test.ts— 13 Storybook Vitest play-function stories covering the full drag lifecycle, status region transitions, size reflection, drop-effect validation, and dev-mode accessible-name warningstest/dropzone.a11y.spec.ts— 6 Playwright ARIA snapshot tests verifying role, accessible name, status region announcements across all four states (default, dragged, filled, filled-and-dragged), keyboard focus behavior, and tab orderMotivation and context
Phase 5 (styling) is complete. These tests close the Phase 6 gate before documentation work begins in Phase 7. They also add an explicit non-regression test for the
dragoverpath always callingevent.preventDefault(), and cover the dev-mode warning when no accessible name is provided.Related issue(s)
Screenshots (if appropriate)
N/A — test-only change
Author's checklist
Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
Vitest play functions pass in headless Chromium
yarn test --story-path=dropzone(or equivalent)Drop Zone/Testspass without timeoutPlaywright ARIA snapshots pass
yarn test:a11ytargeting the drop-zone storiesNo regressions in the
StatesstoryDevice review
Accessibility testing checklist
Keyboard (test-only PR; no interactive behavior changed)
Tabonce; confirm focus lands on the "Browse files" button, not theswc-dropzonehostTabagain moves focus past the component)Screen reader (covered by Playwright ARIA snapshot tests)
group "Dragged drop zone"and reads the status region content"File ready to drop""File accepted""Drop to replace existing file"