Skip to content

Added App close confirmation dialog to fix #18#26

Merged
adeeteya merged 2 commits into
masterfrom
app_close_confirmation_dialog
Oct 5, 2025
Merged

Added App close confirmation dialog to fix #18#26
adeeteya merged 2 commits into
masterfrom
app_close_confirmation_dialog

Conversation

@adeeteya

@adeeteya adeeteya commented Oct 5, 2025

Copy link
Copy Markdown
Owner

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission work for all the platforms?
  2. Have you lint your code locally before submission? (using flutter_lints package)

Now there is a Confirmation Dialog which asks the user whether he is sure he want to exit the app or not.

@adeeteya
adeeteya requested a review from Copilot October 5, 2025 11:30

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Added an app close confirmation dialog to address issue #18, improving user experience by preventing accidental app exits.

  • Implemented exit confirmation dialog using PopScope widget with custom confirmation logic
  • Added new localization strings for the confirmation dialog title and content
  • Updated internationalization files to support the new confirmation dialog text

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
lib/home.dart Added PopScope wrapper and exit confirmation dialog implementation
lib/l10n/app_en.arb Added English localization strings for exit confirmation dialog
untranslated_messages.json Marked new localization keys as needing translation for all supported languages
android/app/src/main/AndroidManifest.xml Enabled predictive back gesture support for Android
lib/widgets/MarkdownTextInput/markdown_text_input.dart Code formatting improvements (unrelated to main feature)
lib/widgets/MarkdownTextInput/format_markdown.dart Code formatting improvements (unrelated to main feature)
lib/main.dart Code formatting improvements (unrelated to main feature)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@adeeteya
adeeteya merged commit 570fc27 into master Oct 5, 2025
1 check passed
@adeeteya
adeeteya deleted the app_close_confirmation_dialog branch October 5, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants