Answer https without connecting upstream.

[ganskef]

This enables a caching proxy for offline use, which is supported with HTTP at the moment for HTTPS too.

It is needed to suppress the handshake to upstream without a connection. Since it's necessary to disable resolving of IP addresses a HostResolver answering unresolved addresses is needed, too. This is used to detect the offline mode in LittleProxy Man-In-The-Middle handling.

[jekh]

While offline it is neccessary to disable resolving of IP addresses. You must have a HostResolver answering unresolved addresses. This is used to detect the offline mode in LittleProxy Man-In-The-Middle handling too.

This is what I’m skeptical of: I don’t think InetSocketAddress.isUnresolved() should be used to say “don’t connect to the upstream server”. The HostResolver’s job isn’t to determine whether to connect to an upstream server; its job is to resolve hosts. I think the “flag” indicating that the CONNECT should be skipped needs to be explicit, and I don’t think it’s related to DNS resolution. Ideally, the decision of whether to connect to the upstream server would be made before the HostResolver is ever invoked.

I personally would love to see a refactoring of ConnectionFlow, but I'm not sure what that would look like. Short of a refactoring, if there's a way to more explicitly indicate "do not connect", that would probably be fine.

[ganskef]

I have squashed the PR into one commit based on the current master. Since the host name is available now, I've updated the initial comment. These are the modifications I like to pull.

I personally would not like to add another option to the connection flow. Checking the unresolved address to indicate the offline state works well and seems to be clear to me. There is a test (setUp) to show what happens. Otherwise I need them both.

[stabbylambda]

I just ran into this issue on a build slave that doesn't have access to the internet. I'm wondering if there's a resolution here?