fix(release): refactor SHA256 hash generation#103
Open
tcely wants to merge 1 commit intoactions:mainfrom
Open
Conversation
- Refactor the hash generation process to improve clarity and ensure valid file creation. - Add a verification step to handle errors more effectively. The previous step generated lines that were invalid. A single space was never acceptable as a field separator. The valid options were: 1) two spaces for text mode or 2) ` *` for binary mode. Since we don't actually want line endings to be translated, marking with two spaces isn't what we should use either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous step generated lines that were invalid.
A single space was never acceptable as a field separator. The valid options were: 1) two spaces for text mode or 2)
*for binary mode. Since we don't actually want line endings to be translated, marking with two spaces isn't what we should use either.