Fix incorrect default starting year in NVD importer #2085
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@Adityakk9031, could you please fix the DCO for this PR? |
Adityakk9031
force-pushed
the
Fix-incorrect-default-starting-year-in-NVD-importer
branch
2 times, most recently
from
b7c0a28 to
701c9b1
Compare
The function fetch_cve_data_1_1 used starting_year=2025 by default, but NVD JSON CVE feeds are available starting from 2002. This caused older CVE data (2002–2024) to be skipped when no starting year was provided. This updates the default starting_year to 2002 so all available NVD CVE data is fetched by default, matching documented behavior. Fixes: aboutcode-org#2079 Signed-off-by: Aditya Kumar Singh <[email protected]> Signed-off-by: Aditya kumar singh <[email protected]>
Adityakk9031
force-pushed
the
Fix-incorrect-default-starting-year-in-NVD-importer
branch
from
701c9b1 to
32127d6
Compare
Author
|
fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The function fetch_cve_data_1_1 in vulnerabilities/pipelines/v2_importers/nvd_importer.py uses starting_year=2025 as the default value.
However, NVD JSON CVE feeds are available starting from 2002, not 2025.
Because of this incorrect default, older CVE data (2002–2024) is skipped when the importer runs without explicitly passing a starting year.
Solution
Updated the default value of starting_year from 2025 to 2002 so the importer correctly fetches all available NVD CVE data by default, matching the documented behavior and NVD feed availability.
Changes Made
Changed fetch_cve_data_1_1(starting_year=2025) → fetch_cve_data_1_1(starting_year=2002)
No other logic or behavior was modified.
Issue Link
Fixes: Incorrect starting year #2079
#2079