Add CMake configuration of LibComm#6
Open
Growl1234 wants to merge 6 commits into
Open
Conversation
Author
|
Looks like CTest detected a potential problem not found before... Let me have a look and fix it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a proper installable CMake package for LibComm, including the
LibComm::LibComminterface target, public-header installation, exported targets, package configuration/version files, and dependency propagation.The main motivation is downstream consumption by ABACUS. Currently, ABACUS has to install LibComm itself and maintain a custom
FindLibComm.cmake, taking over package-management and discovery responsibilities that should belong to the upstream project. With this change, ABACUS and other consumers can simply use:This removes duplicated downstream logic and reduces the maintenance burden for both LibComm and its consumers.
Note: In this CMake logic,
cerealis required to be built with CMake; it's not supported to directly detecting non-installed header files.