Add time-based parachute triggers for delay charge simulation#7
Draft
Add time-based parachute triggers for delay charge simulation#7
Conversation
Co-authored-by: aZira371 <99824864+aZira371@users.noreply.github.com>
…g blank lines Co-authored-by: aZira371 <99824864+aZira371@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add fixed time delay for parachute deployment
Add time-based parachute triggers for delay charge simulation
Dec 20, 2025
Owner
|
@copilot please check the branch is healthy or not check that the code implementation hasnt change due to base brancjh change |
…uplicate doc line Co-authored-by: aZira371 <99824864+aZira371@users.noreply.github.com>
Author
Branch health check complete ✅ Status: The implementation is intact and working correctly after the merge from develop. Issues Found & Fixed:
Verification:
Fixed in commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest tests -m slow --runslow) have passed locallyCHANGELOG.mdhas been updated (if relevant)Current behavior
RocketPy cannot simulate rockets with motor delay charges (fixed-time deployment) like model rocket motors or high-power motors without avionics. Users must resort to workarounds or cannot accurately simulate kits like Loc-IV powered by Aerotech motors with delay elements.
New behavior
Parachute triggers now accept time-based string formats:
"launch + X"- deploys X seconds after t=0"burnout + X"- deploys X seconds after motor burnoutImplementation:
Parachute.__evaluate_trigger_function()to parse time-based triggerst(current time) androcket(motor access) parameters to trigger function signatureFlightclass to pass additional parameters (two original + two added in recent merge)Example usage:
Testing:
Breaking change
Additional information
Existing trigger types (callable, float altitude, "apogee") remain unchanged. The trigger function signature extension uses optional parameters with defaults, ensuring zero-impact to existing code.
Merge Compatibility: The implementation has been verified and updated to work correctly with the latest develop branch changes, including new code paths for parachute trigger checking introduced in recent Flight class refactoring.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.