Make UARTs adhere to the std.Io.Reader interface - #1008
Open
pcolladosoto wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to leverage an UART through an
std.Io.Readerinterface I was met with compilation errors such asThis PR adds changes so that the UART's HAL adheres to the
std.Io.Readerinterface whilst also updating thestreamfunction.The reader implementation works on my side when driving the UART for performing Modbus requests.
If there's anything that should be changed don't hesitate to do so: these are my first steps with Zig!
Thanks a ton for your time.