Skip to content

fix(preview): render JSXGraph diagrams against the live DOM (#68) #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adibhanna merged 1 commit into from
Jun 10, 2026
Merged

fix(preview): render JSXGraph diagrams against the live DOM (#68) #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/app-core/src/components/Preview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -700,9 +700,15 @@ export const Preview = memo(function Preview({
} catch {
/* render errors are surfaced inline per block */
}
await renderDiagrams(stage, { themeKey: effectiveMode, expanded: false });
if (cancelled) return;
// Attach to the live document BEFORE rendering diagrams. JSXGraph binds to
// a real element via document.getElementById and sizes the board from the
// laid-out container, so a detached buffer yields "HTML container element
// not found" and zero-size boards (#68). Mermaid renders to inline SVG, so
// it is safe to render in the detached buffer above.
root.replaceChildren(...Array.from(stage.childNodes));
await renderDiagrams(root, { themeKey: effectiveMode, expanded: false });
if (cancelled) return;
requestAnimationFrame(() => {
if (!cancelled) onRenderedRef.current?.();
});
Expand Down
Loading