fix(keymaps): comments shortcuts + always-on pane focus - #82
Merged
Conversation
Addresses keyboard-shortcut gaps reported by a user: - Toggle Comments panel: add `Mod+Shift+C` (it had a command but no shortcut, unlike the Sidebar/Connections/Outline panels). - Comment a selection without the mouse: add `Mod+Alt+M` (the Google- Docs convention) plus an "Add Comment to Selection" command. Comments the selection, or the current line when nothing is selected. - Focus panes without <C-w>: add always-on `Alt+h/j/k/l` pane/panel focus that works regardless of vim mode. The existing `<C-w>hjkl` prefix is vim-mode-gated, so it's dead when vim mode is off while the palette command still works — `Alt+hjkl` closes that gap and sidesteps Ctrl+W being intercepted on some Linux setups.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses keyboard-shortcut gaps reported by a community member (Kelv).
Changes
⌘⇧C/Ctrl+Shift+C. The command existed but had no shortcut, unlike Sidebar/Connections/Outline (⌘1/2/3). Also surfaced in the command palette.⌥⌘M/Ctrl+Alt+M(the Google-Docs "add comment" convention), plus an Add Comment to Selection palette command. Comments the selection, or the current line when nothing is selected; opens + focuses the panel.Ctrl+W— new always-on⌥h/j/k/l(Alt+hjkl) pane/panel focus. The existing<C-w>hjklis vim-mode-gated, so it does nothing when vim mode is off while the palette command still works (the reporter's exact symptom).Alt+hjklcloses that gap and sidestepsCtrl+Wbeing intercepted on some Linux setups.<C-w>hjklstill works in vim mode.Notes
Alt+hjklchosen to avoid known Ubuntu OS shortcuts (Ctrl+Alt+Arrow = workspaces, Ctrl+Alt+L = lock).Verification
npm run typecheck(7/7),npm run test:run(140 passed / 1 skipped),npm run build(6/6) — all green locally.