fix(editor): focus first row when inserting a table via /table - #602
Closed
junereycasuga wants to merge 1 commit into
Closed
fix(editor): focus first row when inserting a table via /table#602junereycasuga wants to merge 1 commit into
junereycasuga wants to merge 1 commit into
Conversation
junereycasuga
force-pushed
the
fix/table-focus-first-row
branch
3 times, most recently
from
August 20, 2026 08:33
29ccddc to
9371967
Compare
junereycasuga
force-pushed
the
fix/table-focus-first-row
branch
from
August 21, 2026 05:59
9371967 to
c36d328
Compare
Contributor
Author
|
Closing after getting fixed on the v2.36.0 release branch in 24448dc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #663
When inserting a table with
/table, focus now lands in the first header cell instead of being left after the block widget.Changes:
focusTableCell(view, tableFrom, row, col)helper incm-table.ts./tableslash command incm-slash-commands.tsto focus the first header cell once the widget renders.cm-slash-commands.test.tsto assert the first header cell is focused.Tested:
npm run test:run --workspace @zennotes/app-core -- cm-slash-commands.test.tsnpm run typecheck --workspace @zennotes/app-coreBefore:
Cap.2026-08-15.at.12.00.21.mp4
After:
Cap.2026-08-15.at.11.57.30.mp4