Add TGA support and GPL palette export - #94
Draft
Midnoclose wants to merge 10 commits into
Draft
Conversation
slendidev
previously approved these changes
Feb 18, 2023
slendidev
left a comment
slendidev
left a comment
Member
There was a problem hiding this comment.
I have one doubt about something but other than that, LGTM. Did not test, just did a quick look around.
Collaborator
Author
|
Contributes progress towards #27 |
y4my4my4m
self-requested a review
February 25, 2023 21:35
y4my4my4m
requested changes
Feb 25, 2023
y4my4my4m
left a comment
y4my4my4m
left a comment
Collaborator
There was a problem hiding this comment.
Overall seems good but I'd just fix the one part I mentioned.
Also, does this introduce any issues loading/saving palettes for the paletteeditor?
Midnoclose
marked this pull request as draft
March 12, 2023 00:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds TGA reading and writing, as well as a little program to export your palette as a GIMP palette file for external programs