fix: send all matching cookies instead of only the last one#492
Merged
snshn merged 2 commits intoMay 25, 2026
Conversation
When multiple cookies match a URL, the previous code used which overwrote the Cookie header on each iteration, causing only the last matching cookie to be sent. This fix collects all matching cookie name=value pairs and joins them with '; ' (per RFC 6265) into a single Cookie header value. Fixes Y2Z#479
Author
Author
|
CI is green, no conflicts. Fix sends all matching cookies instead of only the last one. Ready for review. |
Member
|
Hello dear sir! Thank you very much for this patch! Good catch, and I'm glad to be able to merge it in for the next release. It seems like the pipeline fails to validate the code format, could you please do |
Author
|
Thanks for the quick review! Ran |
Member
|
No-no, this is great, I'm gonna go ahead and merge this in. If there're any other issues like escaping certain characters, we can do it separately, in another PR. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes a bug where only the last matching cookie was sent when multiple cookies matched a URL.
Why
When using a cookies file with multiple cookies for the same domain, only one cookie would be sent in the HTTP request. This breaks websites that require multiple cookies for authentication or session management.
The root cause was using inside a loop, which overwrote the Cookie header on each iteration.
How
Testing
Fixes #479