fix(eth/downloader): avoid blocking completed state sync spindown by gzliudan · Pull Request #2278 · XinFinOrg/XDPoSChain

gzliudan · 2026-04-06T05:07:07Z

Proposed changes

Stop waiting for timeout or delivery events after a state sync has already completed. Add a regression test to ensure completed spindown returns promptly and resets peer idleness.

error messages:

panic: test timed out after 45m0s
	running tests:
		TestFakedSyncProgress63Fast (44m48s)

goroutine 24402 [running]:
testing.(*M).startAlarm.func1()
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:2682 +0x345
created by time.goFunc
	/opt/hostedtoolcache/go/1.25.8/x64/src/time/sleep.go:215 +0x2d

goroutine 1 [chan receive, 44 minutes]:
testing.tRunner.func1()
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:1891 +0x451
testing.tRunner(0xc000103dc0, 0xc0007dac70)
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:1940 +0x123
testing.runTests(0xc005e9ad68, {0x10c9f20, 0x76, 0x76}, {0x7?, 0xc005eb5040?, 0x111c240?})
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:2475 +0x4b4
testing.(*M).Run(0xc005b42d20)
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:2337 +0x63a
main.main()
	_testmain.go:289 +0x9b

goroutine 7615 [select, 44 minutes]:
github.com/XinFinOrg/XDPoSChain/eth/downloader.(*Downloader).spindownStateSync(0xc003a64ea0, 0xc00dd71e80, {0xc003850998, 0x0, 0x9b7d80?}, 0xc00292ebd0, 0xc00e580700)
	/home/runner/work/XDPoSChain/XDPoSChain/src/XDPoSChain/eth/downloader/statesync.go:223 +0x26f
github.com/XinFinOrg/XDPoSChain/eth/downloader.(*Downloader).runStateSync(0xc003a64ea0, 0xc0000e9680)
	/home/runner/work/XDPoSChain/XDPoSChain/src/XDPoSChain/eth/downloader/statesync.go:131 +0xed2
github.com/XinFinOrg/XDPoSChain/eth/downloader.(*Downloader).stateFetcher(0xc003a64ea0)
	/home/runner/work/XDPoSChain/XDPoSChain/src/XDPoSChain/eth/downloader/statesync.go:85 +0x154
created by github.com/XinFinOrg/XDPoSChain/eth/downloader.New in goroutine 157
	/home/runner/work/XDPoSChain/XDPoSChain/src/XDPoSChain/eth/downloader/downloader.go:247 +0x545

goroutine 7758 [select, 44 minutes]:
github.com/XinFinOrg/XDPoSChain/eth/downloader.(*Downloader).processHeaders(0xc003a64ea0, 0xfc5c1b772cc7f45f?, 0x3ab, 0xc000694440)
	/home/runner/work/XDPoSChain/XDPoSChain/src/XDPoSChain/eth/downloader/downloader.go:1338 +0x23a
github.com/XinFinOrg/XDPoSChain/eth/downloader.(*Downloader).syncWithPeer.func6()
	/home/runner/work/XDPoSChain/XDPoSChain/src/XDPoSChain/eth/downloader/downloader.go:484 +0x36
github.com/XinFinOrg/XDPoSChain/eth/downloader.(*Downloader).spawnSync.func1()
	/home/runner/work/XDPoSChain/XDPoSChain/src/XDPoSChain/eth/downloader/downloader.go:500 +0x70
created by github.com/XinFinOrg/XDPoSChain/eth/downloader.(*Downloader).spawnSync in goroutine 7730
	/home/runner/work/XDPoSChain/XDPoSChain/src/XDPoSChain/eth/downloader/downloader.go:500 +0x9c

goroutine 157 [sync.WaitGroup.Wait, 44 minutes]:
sync.runtime_SemacquireWaitGroup(0xc38cd8?, 0x1?)
	/opt/hostedtoolcache/go/1.25.8/x64/src/runtime/sema.go:114 +0x2e
sync.(*WaitGroup).Wait(0xc0067acab0)
	/opt/hostedtoolcache/go/1.25.8/x64/src/sync/waitgroup.go:206 +0x85
github.com/XinFinOrg/XDPoSChain/eth/downloader.testFakedSyncProgress(0xc008153dc0, 0x3f, 0x1)
	/home/runner/work/XDPoSChain/XDPoSChain/src/XDPoSChain/eth/downloader/downloader_test.go:1499 +0x495
github.com/XinFinOrg/XDPoSChain/eth/downloader.TestFakedSyncProgress63Fast(0xc008153dc0?)
	/home/runner/work/XDPoSChain/XDPoSChain/src/XDPoSChain/eth/downloader/downloader_test.go:1434 +0x1d
testing.tRunner(0xc008153dc0, 0xb92e60)
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:1934 +0xea
created by testing.(*T).Run in goroutine 1
	/opt/hostedtoolcache/go/1.25.8/x64/src/testing/testing.go:1997 +0x465

goroutine 7759 [select, 44 minutes]:
github.com/XinFinOrg/XDPoSChain/eth/downloader.(*Downloader).syncState(0xc003a64ea0, {0x12, 0x8b, 0xbd, 0xce, 0x5e, 0xcf, 0x8f, 0xf5, 0x4f, ...})
	/home/runner/work/XDPoSChain/XDPoSChain/src/XDPoSChain/eth/downloader/statesync.go:65 +0xcf
github.com/XinFinOrg/XDPoSChain/eth/downloader.(*Downloader).processFastSyncContent(0xc003a64ea0, 0xc00068f408)
	/home/runner/work/XDPoSChain/XDPoSChain/src/XDPoSChain/eth/downloader/downloader.go:1570 +0xaa
github.com/XinFinOrg/XDPoSChain/eth/downloader.(*Downloader).syncWithPeer.func7()
	/home/runner/work/XDPoSChain/XDPoSChain/src/XDPoSChain/eth/downloader/downloader.go:487 +0x2b
github.com/XinFinOrg/XDPoSChain/eth/downloader.(*Downloader).spawnSync.func1()
	/home/runner/work/XDPoSChain/XDPoSChain/src/XDPoSChain/eth/downloader/downloader.go:500 +0x70
created by github.com/XinFinOrg/XDPoSChain/eth/downloader.(*Downloader).spawnSync in goroutine 7730
	/home/runner/work/XDPoSChain/XDPoSChain/src/XDPoSChain/eth/downloader/downloader.go:500 +0x9c

goroutine 7756 [select]:
github.com/XinFinOrg/XDPoSChain/eth/downloader.(*Downloader).fetchParts(0xc003a64ea0, 0xc0000f6fc0, 0xc001933f08, 0xc006af2f00, 0xc001933ef8, 0xc001933ed0, 0xc001933f48, 0xc001933f38, 0x0, 0xb931d8, ...)
	/home/runner/work/XDPoSChain/XDPoSChain/src/XDPoSChain/eth/downloader/downloader.go:1141 +0x1ed
github.com/XinFinOrg/XDPoSChain/eth/downloader.(*Downloader).fetchBodies(0xc003a64ea0, 0x2ec)
	/home/runner/work/XDPoSChain/XDPoSChain/src/XDPoSChain/eth/downloader/downloader.go:1069 +0x2a5
github.com/XinFinOrg/XDPoSChain/eth/downloader.(*Downloader).syncWithPeer.func4()
	/home/runner/work/XDPoSChain/XDPoSChain/src/XDPoSChain/eth/downloader/downloader.go:482 +0x2e
github.com/XinFinOrg/XDPoSChain/eth/downloader.(*Downloader).spawnSync.func1()
	/home/runner/work/XDPoSChain/XDPoSChain/src/XDPoSChain/eth/downloader/downloader.go:500 +0x70
created by github.com/XinFinOrg/XDPoSChain/eth/downloader.(*Downloader).spawnSync in goroutine 7730
	/home/runner/work/XDPoSChain/XDPoSChain/src/XDPoSChain/eth/downloader/downloader.go:500 +0x9c

goroutine 7614 [select]:
github.com/XinFinOrg/XDPoSChain/eth/downloader.(*Downloader).qosTuner(0xc003a64ea0)
	/home/runner/work/XDPoSChain/XDPoSChain/src/XDPoSChain/eth/downloader/downloader.go:1792 +0x3ae
created by github.com/XinFinOrg/XDPoSChain/eth/downloader.New in goroutine 157
	/home/runner/work/XDPoSChain/XDPoSChain/src/XDPoSChain/eth/downloader/downloader.go:246 +0x505

goroutine 7755 [select]:
github.com/XinFinOrg/XDPoSChain/eth/downloader.(*Downloader).fetchHeaders(0xc003a64ea0, 0xc00ba651d0, 0x2ec, 0x3ab)
	/home/runner/work/XDPoSChain/XDPoSChain/src/XDPoSChain/eth/downloader/downloader.go:908 +0x12af
github.com/XinFinOrg/XDPoSChain/eth/downloader.(*Downloader).syncWithPeer.func3()
	/home/runner/work/XDPoSChain/XDPoSChain/src/XDPoSChain/eth/downloader/downloader.go:481 +0x36
github.com/XinFinOrg/XDPoSChain/eth/downloader.(*Downloader).spawnSync.func1()
	/home/runner/work/XDPoSChain/XDPoSChain/src/XDPoSChain/eth/downloader/downloader.go:500 +0x70
created by github.com/XinFinOrg/XDPoSChain/eth/downloader.(*Downloader).spawnSync in goroutine 7730
	/home/runner/work/XDPoSChain/XDPoSChain/src/XDPoSChain/eth/downloader/downloader.go:500 +0x9c

goroutine 7757 [select]:
github.com/XinFinOrg/XDPoSChain/eth/downloader.(*Downloader).fetchParts(0xc003a64ea0, 0xc0000f7030, 0xc00060bf08, 0xc006af2f80, 0xc00060bef8, 0xc00060bed0, 0xc00060bf48, 0xc00060bf38, 0x0, 0xb931e8, ...)
	/home/runner/work/XDPoSChain/XDPoSChain/src/XDPoSChain/eth/downloader/downloader.go:1141 +0x1ed
github.com/XinFinOrg/XDPoSChain/eth/downloader.(*Downloader).fetchReceipts(0xc003a64ea0, 0x2ec)
	/home/runner/work/XDPoSChain/XDPoSChain/src/XDPoSChain/eth/downloader/downloader.go:1095 +0x2a5
github.com/XinFinOrg/XDPoSChain/eth/downloader.(*Downloader).syncWithPeer.func5()
	/home/runner/work/XDPoSChain/XDPoSChain/src/XDPoSChain/eth/downloader/downloader.go:483 +0x2e
github.com/XinFinOrg/XDPoSChain/eth/downloader.(*Downloader).spawnSync.func1()
	/home/runner/work/XDPoSChain/XDPoSChain/src/XDPoSChain/eth/downloader/downloader.go:500 +0x70
created by github.com/XinFinOrg/XDPoSChain/eth/downloader.(*Downloader).spawnSync in goroutine 7730
	/home/runner/work/XDPoSChain/XDPoSChain/src/XDPoSChain/eth/downloader/downloader.go:500 +0x9c

goroutine 7730 [chan receive, 44 minutes]:
github.com/XinFinOrg/XDPoSChain/eth/downloader.(*Downloader).spawnSync(0xc003a64ea0, {0xc00020ae00, 0x5, 0x96d4e98be9c4f27f?})
	/home/runner/work/XDPoSChain/XDPoSChain/src/XDPoSChain/eth/downloader/downloader.go:511 +0x1bb
github.com/XinFinOrg/XDPoSChain/eth/downloader.(*Downloader).syncWithPeer(0xc003a64ea0, 0xc00ba651d0, {0x2f, 0x76, 0xfa, 0x1b, 0xa, 0x67, 0x1b, 0xa2, ...}, ...)
	/home/runner/work/XDPoSChain/XDPoSChain/src/XDPoSChain/eth/downloader/downloader.go:491 +0x99a
github.com/XinFinOrg/XDPoSChain/eth/downloader.(*Downloader).synchronise(0xc000805400?, {0xa7eaa1, 0x5}, {0x2f, 0x76, 0xfa, 0x1b, 0xa, 0x67, 0x1b, ...}, ...)
	/home/runner/work/XDPoSChain/XDPoSChain/src/XDPoSChain/eth/downloader/downloader.go:411 +0x4d6
github.com/XinFinOrg/XDPoSChain/eth/downloader.(*downloadTester).sync(0xc0000e92c0, {0xa7eaa1, 0x5}, 0x0, 0x1)
	/home/runner/work/XDPoSChain/XDPoSChain/src/XDPoSChain/eth/downloader/downloader_test.go:108 +0x1c5
github.com/XinFinOrg/XDPoSChain/eth/downloader.testFakedSyncProgress.func3()
	/home/runner/work/XDPoSChain/XDPoSChain/src/XDPoSChain/eth/downloader/downloader_test.go:1487 +0x5c
created by github.com/XinFinOrg/XDPoSChain/eth/downloader.testFakedSyncProgress in goroutine 157
	/home/runner/work/XDPoSChain/XDPoSChain/src/XDPoSChain/eth/downloader/downloader_test.go:1485 +0x425
FAIL	github.com/XinFinOrg/XDPoSChain/eth/downloader	2700.829s

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

Impacted Components

Which parts of the codebase does this PR touch?
Put an ✅ in the boxes that apply

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
Tested on a private network from the genesis block and monitored the chain operating correctly for multiple epochs.
Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
Tested the backwards compatibility.
Tested with XDC nodes running this version co-exist with those running the previous version.
Relevant documentation has been updated as part of this PR
N/A

Stop waiting for timeout or delivery events after a state sync has already completed. Add a regression test to ensure completed spindown returns promptly and resets peer idleness.

coderabbitai · 2026-04-06T05:07:20Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 77edf524-1111-40d4-b972-2f6273c9cfe5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

This PR fixes a state-sync shutdown (spindown) hang in the downloader by short-circuiting the spindown path when the state sync has already completed, preventing tests (and potentially sync) from blocking until timeouts or late deliveries occur.

Changes:

Extend spindownStateSync to accept a completed flag and return immediately after marking peers idle when the state sync is already done.
Update the runStateSync lifecycle handling to invoke spindown with completed=true on s.done.
Add a regression test ensuring completed spindown returns promptly and resets peer idleness.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
`eth/downloader/statesync.go`	Avoids blocking spindown after completion by stopping timers, marking peers idle, and returning early.
`eth/downloader/downloader_test.go`	Adds a regression test to ensure completed spindown does not block and clears `stateIdle`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

fix(eth/downloader): avoid blocking completed state sync spindown

9e72280

Stop waiting for timeout or delivery events after a state sync has already completed. Add a regression test to ensure completed spindown returns promptly and resets peer idleness.

gzliudan requested review from AnilChinchawale, anunay-xin, benjamin202410, Copilot, liam-lai and wanwiset25 April 6, 2026 05:07

Copilot started reviewing on behalf of gzliudan April 6, 2026 05:07 View session

Copilot AI reviewed Apr 6, 2026

View reviewed changes

anunay-xin approved these changes Apr 7, 2026

View reviewed changes

wanwiset25 approved these changes Apr 10, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(eth/downloader): avoid blocking completed state sync spindown#2278

fix(eth/downloader): avoid blocking completed state sync spindown#2278
gzliudan wants to merge 1 commit intoXinFinOrg:dev-upgradefrom
gzliudan:fix-ci-test-timeout

gzliudan commented Apr 6, 2026

Uh oh!

coderabbitai bot commented Apr 6, 2026

Review skipped

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

gzliudan commented Apr 6, 2026

Proposed changes

Types of changes

Impacted Components

Checklist

Uh oh!

coderabbitai bot commented Apr 6, 2026

Review skipped

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants